opnsense-src/sys/dev/axgbe
Zhenlei Huang c7a2636889 axgbe: Fix setting promisc mode
Ethernet drivers should respect IFF_PROMISC rather than IFF_PPROMISC.
The latter is for user-requested promisc mode, it implies the former
but not vice versa. Some in-kernel components such as if_bridge(4) and
bpf(4) will set promisc mode for interfaces on-demand.

While here, update the debugging message to be not confusing.

This was spotted while reviewing markj@ 's work D46524.

Test from Franco shows that the interface seems to be unconditionally
initialized to promisc mode regardless of this fix. That needs further
investigation.

Reviewed by:	markj, Franco Fichtner <franco@opnsense.org>
Tested by:	Franco Fichtner <franco@opnsense.org>
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D46794
2024-10-12 21:56:56 +08:00
..
if_axgbe.c net: Remove unneeded NULL check for the allocated ifnet 2024-06-28 18:16:29 +08:00
if_axgbe_pci.c axgbe: Fix setting promisc mode 2024-10-12 21:56:56 +08:00
xgbe-common.h axgbe: Various stability improvements 2024-04-28 19:57:51 -06:00
xgbe-dcb.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-16 11:54:36 -06:00
xgbe-desc.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-16 11:54:36 -06:00
xgbe-dev.c axgbe: Fix setting promisc mode 2024-10-12 21:56:56 +08:00
xgbe-drv.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-16 11:54:36 -06:00
xgbe-i2c.c axgbe: Various stability improvements 2024-04-28 19:57:51 -06:00
xgbe-mdio.c axgbe: Various link stability and module compatibilty improvements 2024-02-02 12:21:00 -07:00
xgbe-phy-v1.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-16 11:54:36 -06:00
xgbe-phy-v2.c axgbe: Stop checking for failures from malloc(M_WAITOK) 2024-09-03 18:25:25 +08:00
xgbe-ptp.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-16 11:54:36 -06:00
xgbe-sysctl.c axgbe: use standard rounddown_pow_of_two 2024-07-18 13:56:31 -05:00
xgbe-txrx.c axgbe: Various stability improvements 2024-04-28 19:57:51 -06:00
xgbe.h axgbe: Various stability improvements 2024-04-28 19:57:51 -06:00
xgbe_osdep.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-16 11:54:36 -06:00
xgbe_osdep.h axgbe: use bit_foreach 2024-08-12 16:04:32 -05:00