upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-05 14:54:21 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
opnsense-src/sys/dev/igc
History
Mark Johnston 16b24ba872 igc: Remove a bogus register write in igc_if_queues_free() 
As explained in PR 277038, iflib calls IFDI_DETACH() and then
IFDI_QUEUES_FREE().  With igc, the latter writes to a register after it
has been unmapped.

igc_if_detach() already calls igc_release_hw_control(), and looking at
callers of igc_if_queues_free(), that appears to be sufficient.  So,
just remove the igc_release_hw_control() call.

PR:		277038
Reported by:	Mike Belanger <mibelanger@qnx.com>
Reviewed by:	kbowling
Tested by:	kbowling
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D47293

(cherry picked from commit 35d05a14ed)
2024-11-02 14:29:26 +00:00
..
if_igc.c igc: Remove a bogus register write in igc_if_queues_free() 2024-11-02 14:29:26 +00:00
if_igc.h igc: Rename 'struct adapter' to 'struct igc_softc' 2024-10-21 08:10:09 -07:00
igc_api.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-16 11:54:36 -06:00
igc_api.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16 11:54:11 -06:00
igc_base.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-16 11:54:36 -06:00
igc_base.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16 11:54:11 -06:00
igc_defines.h igc: Add NVM/firmware prints and sysctl 2024-10-05 20:49:08 -07:00
igc_hw.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16 11:54:11 -06:00
igc_i225.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-16 11:54:36 -06:00
igc_i225.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16 11:54:11 -06:00
igc_mac.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-16 11:54:36 -06:00
igc_mac.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16 11:54:11 -06:00
igc_nvm.c igc: Add NVM/firmware prints and sysctl 2024-10-05 20:49:08 -07:00
igc_nvm.h igc: Add NVM/firmware prints and sysctl 2024-10-05 20:49:08 -07:00
igc_osdep.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16 11:54:11 -06:00
igc_phy.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-16 11:54:36 -06:00
igc_phy.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16 11:54:11 -06:00
igc_regs.h igc: Remove non-existent legacy absolute and packet timers 2024-10-05 20:48:55 -07:00
igc_txrx.c igc: txrx function prototype cleanup 2024-10-21 08:10:57 -07:00