opnsense-src/sys/dev/sound/macio
Christos Margiolis 516a9c0212 sound: Make device registration more intuitive
The way a sound driver currently registers to sound(4) is using the
following sequence of function calls:

1. pcm_register() to initialize snddev_info.
2. pcm_addchan() calls to create the device's primary channels.
3. pcm_setstatus() to do the final setup.

While using 3 different functions in a specific order might not be very
elegant, this pattern cannot be easily avoided. However, pcm_register()
and pcm_setstatus() are especially confusing, since one would
intuitively expect:

1. pcm_register() to actually do the registration, as opposed to a basic
   initialization.
2. pcm_setstatus() to, as the name suggests, set some kind of status, as
   opposed to finalizing the registration.

This patch renames pcm_register() to pcm_init(), and pcm_setstatus() to
pcm_register(). Drivers are modified accordingly.

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Reviewed by:	dev_submerge.ch
Differential Revision:	https://reviews.freebsd.org/D47325
2024-11-03 20:02:49 +01:00
..
aoa.c sound: Make device registration more intuitive 2024-11-03 20:02:49 +01:00
aoa.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16 11:54:11 -06:00
davbus.c sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16 11:54:11 -06:00
davbusreg.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16 11:54:11 -06:00
i2s.c sound: Stop checking for failures from malloc(M_WAITOK) 2024-09-03 18:25:33 +08:00
onyx.c onyx: Remove unreachable if condition 2024-10-18 10:41:55 +02:00
snapper.c sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16 11:54:11 -06:00
tumbler.c sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16 11:54:11 -06:00