opnsense-src/sys/dev/usb/input
John Baldwin 540ac338d5 uhid_snes: Remove USB_ST_TRANSFERRED handling for the status request.
The result of the request computed in new_status was never returned to
the caller leaving new_status as a set-but-unused variable.  Removing
new_status leaves sc->previous_status as a write-only variable.
Removing sc->previous_status leaves current_status as a write-only
variable, so it collapses down to removing the entire
USB_ST_TRANSFERRED case.

Arguably, all of the support for UHID_SNES_STATUS_DT_RD should be
removed as it doesn't return anything to the caller.  If the request
should be fixed instead then this commit should be reverted and
new_status should be returned to whoever submitted the request.

Differential Revision:	https://reviews.freebsd.org/D34840
2022-04-18 12:27:48 -07:00
..
atp.c atp: Remove unused variable. 2022-04-07 17:01:29 -07:00
uep.c usb: Add a __usbdebug_used for variables only used under #ifdef USB_DEBUG. 2022-04-13 16:08:20 -07:00
uhid.c usb: real freebsd32 support for most ioctls 2021-12-17 21:28:13 +00:00
uhid_snes.c uhid_snes: Remove USB_ST_TRANSFERRED handling for the status request. 2022-04-18 12:27:48 -07:00
ukbd.c ukbd: Fix handling of keyboard ErrorRollOver reports 2021-02-13 21:12:56 +03:00
ums.c ums(4): Start USB xfers on opening of evdev node unconditionally. 2021-05-24 01:41:17 +03:00
usb_rdesc.h Factor-out hardware-independent part of USB HID support to new module 2021-01-08 02:18:42 +03:00
usbhid.c usbhid(4): Be more restrictive about what requests are allowed from user-space. 2022-03-03 10:24:43 +01:00
wmt.c wmt(4): Adapt to recent KPI changes 2021-09-02 22:35:26 +03:00
wsp.c wsp_intr_callback: eliminate write only variable h 2022-04-04 22:30:33 -06:00