mirror of
https://github.com/opnsense/src.git
synced 2026-06-04 22:32:43 -04:00
cd8c3af747
Some Fujitsu Lifebooks return an invalid _BIX object. The first element of _BIX is a revision number, which indicates what elements will follow: * ACPI 4.0 defined _BIX revision 0 with 20 elements. * ACPI 6.0 introduced _BIX revision 1 with 21 elements. The problem is that the offending Lifebooks have the a non-zero _BIX revision, but provide 20 fields only. The ACPICA parser chokes on this [1], but that seems to be inconsequential. More importantly, our own battery info handling code also verifies that for revision > 0, there are at least 21 fields - and refuses to process the invalid _BIX. One workaround would be to introduce special case / quirk handling for Fujitsu Lifebooks. A better one is to relax the requirements check: If there are only 20 elements, treat the _BIX as revision 0, no matter what revision number was provided by the device. Linux doesn't run into this problem by the way because it only supports the 20 fields defined in the ACPI 4.0 spec [3]. It never looks at the revision number or the 21st field added in ACPI 6.0. [1] https://cgit.freebsd.org/src/tree/sys/contrib/dev/acpica/components/namespace/nsprepkg.c#n815 [2] https://cgit.freebsd.org/src/tree/sys/dev/acpica/acpi_cmbat.c#n371 [3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/acpi/battery.c#n418 PR: 252030 Reviewed by: imp MFC After: 2 weeks |
||
|---|---|---|
| .. | ||
| Osd | ||
| acpi.c | ||
| acpi_acad.c | ||
| acpi_apei.c | ||
| acpi_battery.c | ||
| acpi_bus_if.m | ||
| acpi_button.c | ||
| acpi_cmbat.c | ||
| acpi_container.c | ||
| acpi_cpu.c | ||
| acpi_dock.c | ||
| acpi_ec.c | ||
| acpi_ged.c | ||
| acpi_hpet.c | ||
| acpi_hpet.h | ||
| acpi_if.m | ||
| acpi_isab.c | ||
| acpi_lid.c | ||
| acpi_package.c | ||
| acpi_pci.c | ||
| acpi_pci_link.c | ||
| acpi_pcib.c | ||
| acpi_pcib_acpi.c | ||
| acpi_pcib_pci.c | ||
| acpi_pcibvar.h | ||
| acpi_pcivar.h | ||
| acpi_perf.c | ||
| acpi_powerres.c | ||
| acpi_pxm.c | ||
| acpi_quirk.c | ||
| acpi_quirks | ||
| acpi_resource.c | ||
| acpi_smbat.c | ||
| acpi_smbus.h | ||
| acpi_thermal.c | ||
| acpi_throttle.c | ||
| acpi_timer.c | ||
| acpi_video.c | ||
| acpiio.h | ||
| acpivar.h | ||