mirror of
https://github.com/opnsense/src.git
synced 2026-05-04 17:05:14 -04:00
3a60f9c605
Add missing brelse(bp). Without it the cache grows and we have a n^2
lookup. I'm not entirely sure why we read the block before we write it
back out, since the only side effect of that is to allocate memory,
clear the memory, read it in from disk, throw it away with the contents
of the file being written out. We likely should just do a getblk() here
instead, but even with all that, this takes the time it takes to create
a 150MB msdos fs image down from 5 minutes to 30 seconds.
Old: 317.663u 0.685s 5:18.34 100.0% 198+360k 0+19io 1009pf+0w
New: 7.330u 23.841s 0:31.17 100.0% 198+360k 0+250522io 4pf+0w
See code review for how we got this. tl;dr: netbsd move brelse
into bwrite and we picked up msdos code after that, but not the
move. That change should be picked up later.
Sponsored by: Netflix
Reviewed by: emaste
MFC After: 1 day (13.2 is coming fast)
Differential Revision: https://reviews.freebsd.org/D39025
Approved by: re@ (cperciva)
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| cd9660 | ||
| ffs | ||
| msdos | ||
| tests | ||
| cd9660.c | ||
| cd9660.h | ||
| ffs.c | ||
| ffs.h | ||
| Makefile | ||
| Makefile.depend | ||
| makefs.8 | ||
| makefs.c | ||
| makefs.h | ||
| msdos.c | ||
| msdos.h | ||
| mtree.c | ||
| walk.c | ||