From 2c1a7d421f92c14c8fedbd77200607b3df554add Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Tue, 17 Mar 2026 11:24:10 +0200 Subject: [PATCH] Don't leave behind files in src dir in 007_multixact_conversion.pl pg_upgrade test 007_multixact_conversion.pl was leaving files like delete_old_cluster.sh in the source directory for VPATH and meson builds. To fix, change the tmp_check directory before running the test, like in the other pg_upgrade tests. Author: Hayato Kuroda https://www.postgresql.org/message-id/TYRPR01MB121563A4DA8B2FE9A2ECB79F5F541A@TYRPR01MB12156.jpnprd01.prod.outlook.com --- src/bin/pg_upgrade/t/007_multixact_conversion.pl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/bin/pg_upgrade/t/007_multixact_conversion.pl b/src/bin/pg_upgrade/t/007_multixact_conversion.pl index d18c50830d5..867a0623153 100644 --- a/src/bin/pg_upgrade/t/007_multixact_conversion.pl +++ b/src/bin/pg_upgrade/t/007_multixact_conversion.pl @@ -357,6 +357,11 @@ sub upgrade_and_compare 'multixact members from original and upgraded clusters match'); } +# In a VPATH build, we'll be started in the source directory, but we want +# to run pg_upgrade in the build directory so that any files generated finish +# in it, like delete_old_cluster.{sh,bat}. +chdir ${PostgreSQL::Test::Utils::tmp_check}; + my $old_version; # Basic scenario: Create a cluster using old installation, run