Silence compiler warning from older compilers.

Our RHEL7-vintage buildfarm animals are complaining about
"the comparison will always evaluate as true" for a usage of
SOFT_ERROR_OCCURRED() on a local variable.  This is the same
issue addressed in 7bc88c3d6 and some earlier commits, so solve
it the same way: write "escontext.error_occurred" instead.

Problem dates to recent commit a0b6ef29a, no need for back-patch.
This commit is contained in:
Tom Lane 2026-03-23 17:25:12 -04:00
parent 7c08a7e809
commit 2e123e3c2b

View file

@ -7628,7 +7628,7 @@ ATExecAddColumn(List **wqueue, AlteredTableInfo *tab, Relation rel,
* Phase 3 will re-evaluate with hard errors, so the user gets
* an error only if the table has rows.
*/
if (SOFT_ERROR_OCCURRED(&escontext))
if (escontext.error_occurred)
{
missingIsNull = true;
tab->rewrite |= AT_REWRITE_DEFAULT_VAL;