From 3218825271bd5ea3921ecd18e373bc76947c70bc Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Thu, 26 Feb 2026 10:19:23 -0500 Subject: [PATCH] instrumentation: Rename INSTR_TIME_LT macro to INSTR_TIME_GT This was incorrectly named "LT" for "larger than" in e5a5e0a90750d66, but that is against existing conventions, where "LT" means "less than". Clarify by using "GT" for "greater than" in macro name, and add a missing comment at the top of instr_time.h to note the macro's existence. Reported by: Peter Smith Author: Lukas Fittl Reviewed-by: Andres Freund Discussion: https://postgr.es/m/CAHut%2BPut94CTpjQsqOJHdHkgJ2ZXq%2BqVSfMEcmDKLiWLW-hPfA%40mail.gmail.com --- src/backend/executor/instrument.c | 2 +- src/include/portability/instr_time.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/backend/executor/instrument.c b/src/backend/executor/instrument.c index edab92a0ebe..4c3930a4f86 100644 --- a/src/backend/executor/instrument.c +++ b/src/backend/executor/instrument.c @@ -170,7 +170,7 @@ InstrAggNode(Instrumentation *dst, Instrumentation *add) dst->firsttuple = add->firsttuple; } else if (dst->running && add->running && - INSTR_TIME_LT(dst->firsttuple, add->firsttuple)) + INSTR_TIME_GT(dst->firsttuple, add->firsttuple)) dst->firsttuple = add->firsttuple; INSTR_TIME_ADD(dst->counter, add->counter); diff --git a/src/include/portability/instr_time.h b/src/include/portability/instr_time.h index 490593d1825..87b9ec95531 100644 --- a/src/include/portability/instr_time.h +++ b/src/include/portability/instr_time.h @@ -28,6 +28,8 @@ * * INSTR_TIME_ACCUM_DIFF(x, y, z) x += (y - z) * + * INSTR_TIME_GT(x, y) x > y + * * INSTR_TIME_GET_DOUBLE(t) convert t to double (in seconds) * * INSTR_TIME_GET_MILLISEC(t) convert t to double (in milliseconds) @@ -184,7 +186,7 @@ GetTimerFrequency(void) #define INSTR_TIME_ACCUM_DIFF(x,y,z) \ ((x).ticks += (y).ticks - (z).ticks) -#define INSTR_TIME_LT(x,y) \ +#define INSTR_TIME_GT(x,y) \ ((x).ticks > (y).ticks) #define INSTR_TIME_GET_DOUBLE(t) \