upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-07-08 09:10:57 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refine error reporting for null treatment on non-window functions

Browse source 
Commit 4e5920e6de disallowed RESPECT NULLS/IGNORE NULLS on
non-window functions, but it also caused the parser to check for
that clause too early in some cases. As a result, calls such as a
nonexistent function with IGNORE NULLS no longer reported the more
helpful "function ... does not exist" error, and aggregate functions
used as window functions reported "only window functions accept ..."
instead of the more accurate aggregate-specific error.

This commit moves the RESPECT NULLS/IGNORE NULLS checks so that
helpful existing errors are preserved where appropriate. This restores
"function ... does not exist" for nonexistent functions, while still
reporting that plain functions are not window functions and that
aggregates do not accept null treatment.

Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Tatsuo Ishii <ishii@postgresql.org>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/CAHGQGwH7VY_0GkhycyYZ4czkPGL0uGzDyOxk3uuFOSRR7wFY3g@mail.gmail.com
This commit is contained in:
Fujii Masao 2026-06-24 11:42:36 +09:00
parent 4015abe14b
commit 419ce13b70
3 changed files with 32 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/backend/parser/parse_func.c
View file

@ -351,17 +351,15 @@ ParseFuncOrColumn(ParseState *pstate, List *funcname, List *fargs,
errmsg("OVER specified, but %s is not a window function nor an aggregate function",
NameListToString(funcname)),
parser_errposition(pstate, location)));
if (ignore_nulls != NO_NULLTREATMENT)
ereport(ERROR,
(errcode(ERRCODE_WRONG_OBJECT_TYPE),
/*- translator: first %s is a null treatment option, eg IGNORE NULLS */
errmsg("%s specified, but %s is not a window function",
"RESPECT/IGNORE NULLS", NameListToString(funcname)),
parser_errposition(pstate, location)));
}
/*
* NULL TREATEMENT is only allowed for window functions per spec.
*/
if (fdresult != FUNCDETAIL_WINDOWFUNC && ignore_nulls != NO_NULLTREATMENT)
ereport(ERROR,
errcode(ERRCODE_WRONG_OBJECT_TYPE),
errmsg("only window functions accept RESPECT/IGNORE NULLS"),
parser_errposition(pstate, location));
/*
* So far so good, so do some fdresult-type-specific processing.
*/
@ -528,7 +526,14 @@ ParseFuncOrColumn(ParseState *pstate, List *funcname, List *fargs,
errmsg("%s is not an ordered-set aggregate, so it cannot have WITHIN GROUP",
NameListToString(funcname)),
parser_errposition(pstate, location)));
}
if (ignore_nulls != NO_NULLTREATMENT)
ereport(ERROR,
(errcode(ERRCODE_WRONG_OBJECT_TYPE),
errmsg("aggregate functions do not accept RESPECT/IGNORE NULLS"),
parser_errposition(pstate, location)));
}
else if (fdresult == FUNCDETAIL_WINDOWFUNC)
{

17
src/test/regress/expected/window.out
View file

@ -5748,6 +5748,19 @@ WINDOW w AS (ORDER BY name ROWS BETWEEN 2 PRECEDING AND 2 FOLLOWING EXCLUDE CURR
(10 rows)
-- valid and invalid functions
SELECT abs(1) IGNORE NULLS; -- fails
ERROR: RESPECT/IGNORE NULLS specified, but abs is not a window function
LINE 1: SELECT abs(1) IGNORE NULLS;
^
SELECT no_such_window_func() IGNORE NULLS; -- fails, but not because of null treatment
ERROR: function no_such_window_func() does not exist
LINE 1: SELECT no_such_window_func() IGNORE NULLS;
^
DETAIL: There is no function of that name.
SELECT sum(orbit) IGNORE NULLS FROM planets; -- fails
ERROR: aggregate functions do not accept RESPECT/IGNORE NULLS
LINE 1: SELECT sum(orbit) IGNORE NULLS FROM planets;
^
SELECT sum(orbit) OVER () FROM planets; -- succeeds
sum
--------
@ -5764,11 +5777,11 @@ SELECT sum(orbit) OVER () FROM planets; -- succeeds
(10 rows)
SELECT sum(orbit) RESPECT NULLS OVER () FROM planets; -- fails
ERROR: only window functions accept RESPECT/IGNORE NULLS
ERROR: aggregate functions do not accept RESPECT/IGNORE NULLS
LINE 1: SELECT sum(orbit) RESPECT NULLS OVER () FROM planets;
^
SELECT sum(orbit) IGNORE NULLS OVER () FROM planets; -- fails
ERROR: only window functions accept RESPECT/IGNORE NULLS
ERROR: aggregate functions do not accept RESPECT/IGNORE NULLS
LINE 1: SELECT sum(orbit) IGNORE NULLS OVER () FROM planets;
^
SELECT row_number() OVER () FROM planets; -- succeeds

3
src/test/regress/sql/window.sql
View file

@ -2099,6 +2099,9 @@ WINDOW w AS (ORDER BY name ROWS BETWEEN 2 PRECEDING AND 2 FOLLOWING EXCLUDE CURR
;
-- valid and invalid functions
SELECT abs(1) IGNORE NULLS; -- fails
SELECT no_such_window_func() IGNORE NULLS; -- fails, but not because of null treatment
SELECT sum(orbit) IGNORE NULLS FROM planets; -- fails
SELECT sum(orbit) OVER () FROM planets; -- succeeds
SELECT sum(orbit) RESPECT NULLS OVER () FROM planets; -- fails
SELECT sum(orbit) IGNORE NULLS OVER () FROM planets; -- fails