upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-07-08 01:01:01 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

amcheck: Fix memory leak with gin_index_check()

Browse source 
"prev_tuple" was overwritten with a new tuple coming from
CopyIndexTuple() on each loop, leaking memory for every tuple processed
on entry tree pages.  The function uses a dedicated memory context, but
this could leave unused large areas of memory while processing a large
GIN index, the larger the worse.

Oversight in 14ffaece0f.

Author: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Ewan Young <kdbase.hack@gmail.com>
Discussion: https://postgr.es/m/CALdSSPjTS6TYe5=5NfMUBYZyQu5cn=ABL6K5_OZjzGWqnwXeBw@mail.gmail.com
Backpatch-through: 18
This commit is contained in:
Michael Paquier 2026-07-06 09:32:28 +09:00
parent 56e892a494
commit 80cfd8aef6
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
contrib/amcheck/verify_gin.c
View file

@ -637,6 +637,9 @@ gin_check_parent_keys_consistency(Relation rel,
pfree(ipd);
}
if (prev_tuple)
pfree(prev_tuple);
prev_tuple = CopyIndexTuple(idxtuple);
prev_attnum = current_attnum;
}