upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-02-24 10:25:42 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Check version before allocating PQExpBuffer

Browse source 
In pg_dump.c:getEventTriggers, check what major version we are on
before calling createPQExpBuffer() to avoid leaking that bit of
memory.

Leak discovered by the Coverity scanner.

Back-patch to 9.3 where support for dumping event triggers was
added.
This commit is contained in:
Stephen Frost 2013-07-14 21:17:59 -04:00
parent b68a1fc7ff
commit 8126bfb5b5
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/bin/pg_dump/pg_dump.c
View file

@ -5746,7 +5746,7 @@ EventTriggerInfo *
getEventTriggers(Archive *fout, int *numEventTriggers)
{
int i;
PQExpBuffer query = createPQExpBuffer();
PQExpBuffer query;
PGresult *res;
EventTriggerInfo *evtinfo;
int i_tableoid,
@ -5766,6 +5766,8 @@ getEventTriggers(Archive *fout, int *numEventTriggers)
return NULL;
}
query = createPQExpBuffer();
/* Make sure we are in proper schema */
selectSourceSchema(fout, "pg_catalog");