upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-03-09 17:50:43 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

logical decoding: beware of an unset specinsert change

Browse source 
Coverity complains that there is no protection in the code (at least in
non-assertion-enabled builds) against speculative insertion failing to
follow the expected protocol.  Add an elog(ERROR) for the case.
This commit is contained in:
Alvaro Herrera 2018-07-05 17:42:37 -04:00
parent 301b2a1aad
commit 95b6a40915
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/backend/replication/logical/reorderbuffer.c
View file

@ -1572,6 +1572,8 @@ ReorderBufferCommit(ReorderBuffer *rb, TransactionId xid,
* use as a normal record. It'll be cleaned up at the end
* of INSERT processing.
*/
if (specinsert == NULL)
elog(ERROR, "invalid ordering of speculative insertion changes");
Assert(specinsert->data.tp.oldtuple == NULL);
change = specinsert;
change->action = REORDER_BUFFER_CHANGE_INSERT;