upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-03-01 21:01:12 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix bogus tar-file padding logic for standby.signal.

Browse source 
When pg_basebackup -R is used, we inject standby.signal into the
tar file for the main tablespace. The proper thing to do is to pad
each file injected into the tar file out to a 512-byte boundary
by appending nulls, but here the file is of length 0 and we add
511 zero bytes.  Since 0 is already a multiple of 512, we should
not add any zero bytes. Do that instead.

Patch by me, reviewed by Tom Lane.

Discussion: http://postgr.es/m/CA+TgmobWbfReO9-XFk8urR1K4wTNwqoHx_v56t7=T8KaiEoKNw@mail.gmail.com
This commit is contained in:
Robert Haas 2020-04-27 13:04:35 -04:00
parent 18f7e856cd
commit a08bfe7424
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/bin/pg_basebackup/pg_basebackup.c
View file

@ -1131,7 +1131,12 @@ ReceiveTarFile(PGconn *conn, PGresult *res, int rownum)
time(NULL));
WRITE_TAR_DATA(header, sizeof(header));
WRITE_TAR_DATA(zerobuf, 511);
/*
* we don't need to pad out to a multiple of the tar block
* size here, because the file is zero length, which is a
* multiple of any block size.
*/
}
}