upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-02-28 12:20:43 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Tolerate EINVAL when calling fsync() on a directory.

Browse source 
Previously, we tolerated EBADF as a way for the operating system to
indicate that it doesn't support fsync() on a directory.  Tolerate
EINVAL too, for older versions of Linux CIFS.

Bug #15636.  Back-patch all the way.

Reported-by: John Klann
Discussion: https://postgr.es/m/15636-d380890dafd78fc6@postgresql.org
This commit is contained in:
Thomas Munro 2019-02-24 23:59:26 +13:00
parent 99a1554a26
commit ede6b19624
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/backend/storage/file/fd.c
View file

@ -2944,7 +2944,7 @@ fsync_fname_ext(const char *fname, bool isdir, bool ignore_perm, int elevel)
* Some OSes don't allow us to fsync directories at all, so we can ignore
* those errors. Anything else needs to be logged.
*/
if (returncode != 0 && !(isdir && errno == EBADF))
if (returncode != 0 && !(isdir && (errno == EBADF || errno == EINVAL)))
{
int save_errno;

2
src/bin/initdb/initdb.c
View file

@ -696,7 +696,7 @@ fsync_fname_ext(const char *fname, bool isdir)
* Some OSes don't allow us to fsync directories at all, so we can ignore
* those errors. Anything else needs to be reported.
*/
if (returncode != 0 && !(isdir && errno == EBADF))
if (returncode != 0 && !(isdir && (errno == EBADF || errno == EINVAL)))
fprintf(stderr, _("%s: could not fsync file \"%s\": %s\n"),
progname, fname, strerror(errno));