upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-02-14 08:13:27 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

pg_test_fsync: add C comment about direct I/O and write size failure

Browse source 
Report from Marti Raudsepp
This commit is contained in:
Bruce Momjian 2014-02-12 15:38:14 -05:00
parent 6f2aead1ff
commit f9bb944cd8
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
contrib/pg_test_fsync/pg_test_fsync.c
View file

@ -369,6 +369,12 @@ test_sync(int writes_per_op)
{
for (writes = 0; writes < writes_per_op; writes++)
if (write(tmpfile, buf, XLOG_BLCKSZ) != XLOG_BLCKSZ)
/*
* This can generate write failures if the filesystem
* has a large block size, e.g. 4k, and there is no
* support for O_DIRECT writes smaller than the
* file system block size, e.g. XFS.
*/
die("write failed");
if (lseek(tmpfile, 0, SEEK_SET) == -1)
die("seek failed");