upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-07-06 16:25:55 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Restore basebackup_progress_done() to preserve ABI

Browse source 
Commit e7564ee8cd, which fixed base backup progress reporting on
backup failure, removed the external function basebackup_progress_done()
because it was no longer used in core. When that change was backpatched
to v15, it introduced an ABI break, which was reported by buildfarm
member crake.

This commit restores basebackup_progress_done() to preserve ABI
compatibility, even though it is no longer used in core, rather than
updating the .abi-compliance-history file. Because external backup
tools may still call this function.

Per buildfarm member crake.

Reported-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/CAD5tBcJ+ktrEp=PT8Gq-f=8mA2cDtZMB-hDMV4mMJ+9V46qBeQ@mail.gmail.com
Backpatch-through: 15-18
This commit is contained in:
Fujii Masao 2026-07-06 09:46:15 +09:00
parent a69503fb1e
commit fffa4d870b
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/backend/backup/basebackup_progress.c
View file

@ -246,3 +246,15 @@ basebackup_progress_transfer_wal(void)
pgstat_progress_update_param(PROGRESS_BASEBACKUP_PHASE,
PROGRESS_BASEBACKUP_PHASE_TRANSFER_WAL);
}
/*
* Advertise that we are no longer performing a backup.
*
* No longer used in core, but kept to preserve ABI compatibility in this
* branch.
*/
void
basebackup_progress_done(void)
{
pgstat_progress_end_command();
}

1
src/include/backup/basebackup_sink.h
View file

@ -296,5 +296,6 @@ extern void basebackup_progress_wait_checkpoint(void);
extern void basebackup_progress_estimate_backup_size(void);
extern void basebackup_progress_wait_wal_archive(bbsink_state *);
extern void basebackup_progress_transfer_wal(void);
extern void basebackup_progress_done(void);
#endif