upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-02-03 20:40:14 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions
postgresql/src/test
History
Michael Paquier 50b797dc99 Fix DROP ROLE when specifying duplicated roles 
This commit fixes failures with "tuple already updated by self" when
listing twice the same role and in a DROP ROLE query.

This is an oversight in 6566133c5f, that has introduced a two-phase
logic in DropRole() where dependencies of all the roles to drop are
removed in a first phase, with the roles themselves removed from
pg_authid in a second phase.

The code is simplified to not rely on a List of ObjectAddress built in
the first phase used to remove the pg_authid entries in the second
phase, switching to a list of OIDs.  Duplicated OIDs can be simply
avoided in the first phase thanks to that.  Using ObjectAddress was not
necessary for the roles as they are not used for anything specific to
dependency.c, building all the ObjectAddress in the List with
AuthIdRelationId as class ID.

In 15 and older versions, where a single phase is used, DROP ROLE with
duplicated role names would fail on "role \"blah\" does not exist" for
the second entry after the CCI() done by the first deletion.  This is
not really incorrect, but it does not seem worth changing based on a
lack of complaints.

Reported-by: Alexander Lakhin
Reviewed-by: Tender Wang
Discussion: https://postgr.es/m/18310-1eb233c5908189c8@postgresql.org
Backpatch-through: 16
2024-01-29 08:05:59 +09:00
..
authentication Update copyright for 2024 2024-01-03 20:49:05 -05:00
examples Update copyright for 2024 2024-01-03 20:49:05 -05:00
icu Update copyright for 2024 2024-01-03 20:49:05 -05:00
isolation Make spelling of cancelled/cancellation consistent 2024-01-26 12:38:15 +01:00
kerberos Update copyright for 2024 2024-01-03 20:49:05 -05:00
ldap Update copyright for 2024 2024-01-03 20:49:05 -05:00
locale Update copyright for 2024 2024-01-03 20:49:05 -05:00
mb Fix MB regression tests for WAL-logging of hash indexes. 2017-03-15 07:25:36 -04:00
modules Fix some typos 2024-01-22 13:55:25 +09:00
perl Fix an issue in PostgreSQL::Test::Cluster:psql() 2024-01-18 08:46:42 +01:00
recovery Make spelling of cancelled/cancellation consistent 2024-01-26 12:38:15 +01:00
regress Fix DROP ROLE when specifying duplicated roles 2024-01-29 08:05:59 +09:00
ssl Update copyright for 2024 2024-01-03 20:49:05 -05:00
subscription Fix buildfarm error from commit 5c31669058. 2024-01-18 14:59:59 -08:00
Makefile Refactor PG_TEST_EXTRA logic in autoconf build 2022-09-20 11:24:16 -07:00
meson.build Update copyright for 2024 2024-01-03 20:49:05 -05:00
README Remove the option to build thread_test.c outside configure. 2020-10-21 12:08:48 -04:00

README 

PostgreSQL tests
================

This directory contains a variety of test infrastructure as well as some of the
tests in PostgreSQL. Not all tests are here -- in particular, there are more in
individual contrib/ modules and in src/bin.

Not all these tests get run by "make check". Check src/test/Makefile to see
which tests get run automatically.

authentication/
  Tests for authentication (but see also below)

examples/
  Demonstration programs for libpq that double as regression tests via
  "make check"

isolation/
  Tests for concurrent behavior at the SQL level

kerberos/
  Tests for Kerberos/GSSAPI authentication and encryption

ldap/
  Tests for LDAP-based authentication

locale/
  Sanity checks for locale data, encodings, etc

mb/
  Tests for multibyte encoding (UTF-8) support

modules/
  Extensions used only or mainly for test purposes, generally not suitable
  for installing in production databases

perl/
  Infrastructure for Perl-based TAP tests

recovery/
  Test suite for recovery and replication

regress/
  PostgreSQL's main regression test suite, pg_regress

ssl/
  Tests to exercise and verify SSL certificate handling

subscription/
  Tests for logical replication