Tom Lane 0b6edb9fb3 Fix ALTER COLUMN TYPE failure with a partial exclusion constraint. ... ATExecAlterColumnType failed to consider the possibility that an index that needs to be rebuilt might be a child of a constraint that needs to be rebuilt. We missed this so far because usually a constraint index doesn't have a direct dependency on its table, just on the constraint object. But if there's a WHERE clause, then dependency analysis of the WHERE clause results in direct dependencies on the column(s) mentioned in WHERE. This led to trying to drop and rebuild both the constraint and its underlying index. In v11/HEAD, we successfully drop both the index and the constraint, and then try to rebuild both, and of course the second rebuild hits a duplicate-index-name problem. Before v11, it fails with obscure messages about a missing relation OID, due to trying to drop the index twice. This is essentially the same kind of problem noted in commit 20bef2c31: the possible dependency linkages are broader than what ATExecAlterColumnType was designed for. It was probably OK when written, but it's certainly been broken since the introduction of partial exclusion constraints. Fix by adding an explicit check for whether any of the indexes-to-be-rebuilt belong to any of the constraints-to-be-rebuilt, and ignoring any that do. In passing, fix a latent bug introduced by commit 8b08f7d48: in get_constraint_index() we must "continue" not "break" when rejecting a relation of a wrong relkind. This is harmless today because we don't expect that code path to be taken anyway; but if there ever were any relations to be ignored, the existing coding would have an extremely undesirable dependency on the order of pg_depend entries. Also adjust a couple of obsolete comments. Per bug #15835 from Yaroslav Schekin. Back-patch to all supported branches. Discussion: https://postgr.es/m/15835-32d9b7a76c06a7a9@postgresql.org		2019-06-12 12:29:41 -04:00
..
backend	Fix ALTER COLUMN TYPE failure with a partial exclusion constraint.	2019-06-12 12:29:41 -04:00
bin	Make pg_dump emit ATTACH PARTITION instead of PARTITION OF (reprise)	2019-06-10 18:56:23 -04:00
common	Tolerate EINVAL when calling fsync() on a directory.	2019-02-24 23:51:54 +13:00
fe_utils	Fix translation of special characters in psql's LaTeX output modes.	2018-11-26 17:32:51 -05:00
include	Restructure creation of run-time pruning steps.	2019-05-17 19:44:19 -04:00
interfaces	Fix misuse of an integer as a bool.	2019-05-13 10:53:19 -04:00
makefiles	Define WIN32_STACK_RLIMIT throughout win32 and cygwin builds.	2019-04-09 08:25:42 -07:00
pl	Fix C++ incompatibilities in plpgsql's header files.	2019-05-31 12:34:54 -04:00
port	Stamp 11.3.	2019-05-06 16:46:18 -04:00
template	Yet further rethinking of build changes for macOS Mojave.	2018-11-02 18:54:00 -04:00
test	Fix ALTER COLUMN TYPE failure with a partial exclusion constraint.	2019-06-12 12:29:41 -04:00
timezone	Portability fix for zic.c.	2019-04-26 21:20:21 -04:00
tools	In the pg_upgrade test suite, don't write to src/test/regress.	2019-05-28 12:59:36 -07:00
tutorial	Update copyright for 2018	2018-01-02 23:30:12 -05:00
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	2010-09-22 12:57:04 +02:00
DEVELOPERS	Replace a couple of references to files that no longer exist in the source	2009-05-04 08:08:47 +00:00
Makefile	Fix partial-build problems introduced by having more generated headers.	2018-04-09 16:42:10 -04:00
Makefile.global.in	Consistently test for in-use shared memory.	2019-04-12 22:36:42 -07:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk	nls-global.mk: search build dir for source files, too	2016-06-07 18:55:18 -04:00