postgresql/src/backend/utils/sort
Tom Lane 3cfecae3a3 Fix failure to account for memory used by tuplestore_putvalues().
This oversight could result in a tuplestore using much more than the
intended amount of memory.  It would only happen in a code path that loaded
a tuplestore via tuplestore_putvalues(), and many of those won't emit huge
amounts of data; but cases such as holdable cursors and plpgsql's RETURN
NEXT command could have the problem.  The fix ensures that the tuplestore
will switch to write-to-disk mode when it overruns work_mem.

The potential overrun was finite, because we would still count the space
used by the tuple pointer array, so the tuplestore code would eventually
flip into write-to-disk mode anyway.  When storing wide tuples we would
go far past the expected work_mem usage before that happened; but this
may account for the lack of prior reports.

Back-patch to 8.4, where tuplestore_putvalues was introduced.

Per bug #6061 from Yann Delorme.
2011-06-15 14:05:39 -04:00
..
logtape.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
Makefile Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
tuplesort.c Pass collations to functions in FunctionCallInfoData, not FmgrInfo. 2011-04-12 19:19:24 -04:00
tuplestore.c Fix failure to account for memory used by tuplestore_putvalues(). 2011-06-15 14:05:39 -04:00