postgresql/src/backend/nodes
Tom Lane 1c2cb2744b Fix run-time partition pruning for appends with multiple source rels.
The previous coding here supposed that if run-time partitioning applied to
a particular Append/MergeAppend plan, then all child plans of that node
must be members of a single partitioning hierarchy.  This is totally wrong,
since an Append could be formed from a UNION ALL: we could have multiple
hierarchies sharing the same Append, or child plans that aren't part of any
hierarchy.

To fix, restructure the related plan-time and execution-time data
structures so that we can have a separate list or array for each
partitioning hierarchy.  Also track subplans that are not part of any
hierarchy, and make sure they don't get pruned.

Per reports from Phil Florent and others.  Back-patch to v11, since
the bug originated there.

David Rowley, with a lot of cosmetic adjustments by me; thanks also
to Amit Langote for review.

Discussion: https://postgr.es/m/HE1PR03MB17068BB27404C90B5B788BCABA7B0@HE1PR03MB1706.eurprd03.prod.outlook.com
2018-08-01 19:42:52 -04:00
..
bitmapset.c Remove dead code left behind by 1b6801051. 2018-07-30 19:11:02 -04:00
copyfuncs.c Fix run-time partition pruning for appends with multiple source rels. 2018-08-01 19:42:52 -04:00
equalfuncs.c Refactor cluster_rel() to handle more options 2018-07-24 11:37:32 +09:00
extensible.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
list.c Rewrite list_qsort() to avoid trashing its input list. 2018-01-09 13:25:53 -05:00
Makefile Introduce extensible node types. 2016-02-12 09:38:11 -05:00
makefuncs.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
nodeFuncs.c Revert MERGE patch 2018-04-12 11:22:56 +01:00
nodes.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
outfuncs.c Fix run-time partition pruning for appends with multiple source rels. 2018-08-01 19:42:52 -04:00
params.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
print.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
read.c Post-feature-freeze pgindent run. 2018-04-26 14:47:16 -04:00
readfuncs.c Fix run-time partition pruning for appends with multiple source rels. 2018-08-01 19:42:52 -04:00
README Fix various common mispellings. 2016-06-03 16:08:45 +01:00
tidbitmap.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
value.c Change internal integer representation of Value node 2018-03-13 09:56:25 -04:00

src/backend/nodes/README

Node Structures
===============

Andrew Yu (11/94)

Introduction
------------

The current node structures are plain old C structures. "Inheritance" is
achieved by convention. No additional functions will be generated. Functions
that manipulate node structures reside in this directory.


FILES IN THIS DIRECTORY (src/backend/nodes/)

    General-purpose node manipulation functions:
	copyfuncs.c	- copy a node tree
	equalfuncs.c	- compare two node trees
	outfuncs.c	- convert a node tree to text representation
	readfuncs.c	- convert text representation back to a node tree
	makefuncs.c	- creator functions for some common node types
	nodeFuncs.c	- some other general-purpose manipulation functions

    Specialized manipulation functions:
	bitmapset.c	- Bitmapset support
	list.c		- generic list support
	params.c	- Param support
	tidbitmap.c	- TIDBitmap support
	value.c		- support for Value nodes

FILES IN src/include/nodes/

    Node definitions:
	nodes.h		- define node tags (NodeTag)
	primnodes.h	- primitive nodes
	parsenodes.h	- parse tree nodes
	plannodes.h	- plan tree nodes
	relation.h	- planner internal nodes
	execnodes.h	- executor nodes
	memnodes.h	- memory nodes
	pg_list.h	- generic list


Steps to Add a Node
-------------------

Suppose you want to define a node Foo:

1. Add a tag (T_Foo) to the enum NodeTag in nodes.h.  (If you insert the
   tag in a way that moves the numbers associated with existing tags,
   you'll need to recompile the whole tree after doing this.  It doesn't
   force initdb though, because the numbers never go to disk.)
2. Add the structure definition to the appropriate include/nodes/???.h file.
   If you intend to inherit from, say a Plan node, put Plan as the first field
   of your struct definition.
3. If you intend to use copyObject, equal, nodeToString or stringToNode,
   add an appropriate function to copyfuncs.c, equalfuncs.c, outfuncs.c
   and readfuncs.c accordingly.  (Except for frequently used nodes, don't
   bother writing a creator function in makefuncs.c)  The header comments
   in those files give general rules for whether you need to add support.
4. Add cases to the functions in nodeFuncs.c as needed.  There are many
   other places you'll probably also need to teach about your new node
   type.  Best bet is to grep for references to one or two similar existing
   node types to find all the places to touch.


Historical Note
---------------

Prior to the current simple C structure definitions, the Node structures
used a pseudo-inheritance system which automatically generated creator and
accessor functions. Since every node inherited from LispValue, the whole thing
was a mess. Here's a little anecdote:

    LispValue definition -- class used to support lisp structures
    in C.  This is here because we did not want to totally rewrite
    planner and executor code which depended on lisp structures when
    we ported postgres V1 from lisp to C. -cim 4/23/90