Alvaro Herrera 1eb8a5ea46 Make pg_dump emit ATTACH PARTITION instead of PARTITION OF (reprise) ... Using PARTITION OF can result in column ordering being changed from the database being dumped, if the partition uses a column layout different from the parent's. It's not pg_dump's job to editorialize on table definitions, so this is not acceptable; back-patch all the way back to pg10, where partitioned tables where introduced. This change also ensures that partitions end up in the correct tablespace, if different from the parent's; this is an oversight in ca4103025d (in pg12 only). Partitioned indexes (in pg11) don't have this problem, because they're already created as independent indexes and attached to their parents afterwards. This change also has the advantage that the partition is restorable from the dump (as a standalone table) even if its parent table isn't restored. The original commits (3b23552ad8 in branch master) failed to cover subsidiary column elements correctly, such as NOT NULL constraint and CHECK constraints, as reported by Rushabh Lathia (initially as a failure to restore serial columns). They were reverted. This recapitulation commit fixes those problems. Add some pg_dump tests to verify these things more exhaustively, including constraints with legacy-inheritance tables, which were not tested originally. In branches 10 and 11, add a local constraint to the pg_dump test partition that was added by commit 2d7eeb1b14 to master. Author: Álvaro Herrera, David Rowley Reviewed-by: Álvaro Herrera Discussion: https://postgr.es/m/CAKJS1f_1c260nOt_vBJ067AZ3JXptXVRohDVMLEBmudX1YEx-A@mail.gmail.com Discussion: https://postgr.es/m/20190423185007.GA27954@alvherre.pgsql Discussion: https://postgr.es/m/CAGPqQf0iQV=PPOv2Btog9J9AwOQp6HmuVd6SbGTR_v3Zp2XT1w@mail.gmail.com		2019-06-10 18:56:23 -04:00
..
backend	Fix inconsistency in comments atop ExecParallelEstimate.	2019-06-07 05:35:31 +05:30
bin	Make pg_dump emit ATTACH PARTITION instead of PARTITION OF (reprise)	2019-06-10 18:56:23 -04:00
common	Tolerate EINVAL when calling fsync() on a directory.	2019-02-24 23:52:20 +13:00
fe_utils	Fix translation of special characters in psql's LaTeX output modes.	2018-11-26 17:32:51 -05:00
include	Mark a few parallelism-related variables with PGDLLIMPORT.	2019-06-03 21:25:43 -04:00
interfaces	Fix misuse of an integer as a bool.	2019-05-13 10:53:19 -04:00
makefiles	Define WIN32_STACK_RLIMIT throughout win32 and cygwin builds.	2019-04-09 08:25:42 -07:00
pl	Fix C++ incompatibilities in plpgsql's header files.	2019-05-31 12:34:54 -04:00
port	Stamp 10.8.	2019-05-06 16:48:45 -04:00
template	Yet further rethinking of build changes for macOS Mojave.	2018-11-02 18:54:00 -04:00
test	In the pg_upgrade test suite, don't write to src/test/regress.	2019-05-28 13:00:16 -07:00
timezone	Portability fix for zic.c.	2019-04-26 21:20:27 -04:00
tools	MSVC: Add "use File::Path qw(rmtree)".	2019-05-28 19:28:36 -07:00
tutorial	Phase 2 of pgindent updates.	2017-06-21 15:19:25 -04:00
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	2010-09-22 12:57:04 +02:00
DEVELOPERS	Replace a couple of references to files that no longer exist in the source	2009-05-04 08:08:47 +00:00
Makefile	Build src/test/isolation during "make" and "make install".	2017-11-22 20:18:52 -08:00
Makefile.global.in	Consistently test for in-use shared memory.	2019-04-12 22:36:42 -07:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk	nls-global.mk: search build dir for source files, too	2016-06-07 18:55:18 -04:00