mirror of
https://github.com/postgres/postgres.git
synced 2026-02-16 09:08:23 -05:00
1f7e9ba3ac
This commit fixes three issues: 1) When a disabled subscription is created with retain_dead_tuples set to true, the launcher is not woken up immediately, which may lead to delays in creating the conflict detection slot. Creating the conflict detection slot is essential even when the subscription is not enabled. This ensures that dead tuples are retained, which is necessary for accurately identifying the type of conflict during replication. 2) Conflict-related data was unnecessarily retained when the subscription does not have a table. 3) Conflict-relevant data could be prematurely removed before applying prepared transactions on the publisher that are in the commit critical section. This issue occurred because the backend executing COMMIT PREPARED was not accounted for during the computation of oldestXid in the commit phase on the publisher. As a result, the subscriber could advance the conflict slot's xmin without waiting for such COMMIT PREPARED transactions to complete. We fixed this issue by identifying prepared transactions that are in the commit critical section during computation of oldestXid in commit phase. Author: Zhijie Hou <houzj.fnst@fujitsu.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Reviewed-by: Dilip Kumar <dilipbalaut@gmail.com> Reviewed-by: Nisha Moond <nisha.moond412@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/OS9PR01MB16913DACB64E5721872AA5C02943BA@OS9PR01MB16913.jpnprd01.prod.outlook.com Discussion: https://postgr.es/m/OS9PR01MB16913F67856B0DA2A909788129400A@OS9PR01MB16913.jpnprd01.prod.outlook.com |
||
|---|---|---|
| .. | ||
| conflict.h | ||
| decode.h | ||
| logical.h | ||
| logicallauncher.h | ||
| logicalproto.h | ||
| logicalrelation.h | ||
| logicalworker.h | ||
| message.h | ||
| origin.h | ||
| output_plugin.h | ||
| pgoutput.h | ||
| reorderbuffer.h | ||
| slot.h | ||
| slotsync.h | ||
| snapbuild.h | ||
| snapbuild_internal.h | ||
| syncrep.h | ||
| walreceiver.h | ||
| walsender.h | ||
| walsender_private.h | ||
| worker_internal.h | ||