Tom Lane 224256f890 Remove ruleutils.c's special case for BIT [VARYING] literals. ... Up to now, get_const_expr() insisted on prefixing BIT and VARBIT literals with 'B'. That's not really necessary, because we always append explicit-cast syntax to identify the constant's type. Moreover, it's subtly wrong for VARBIT, because the parser will interpret B'...' as '...'::"bit"; see make_const() which explicitly assigns type BITOID for a T_BitString literal. So what had been a simple VARBIT literal is reconstructed as ('...'::"bit")::varbit, which is not the same thing, at least not before constant folding. This results in odd differences after dump/restore, as complained of by the patch submitter, and it could result in actual failures in partitioning or inheritance DDL operations (see commit 542320c2b, which repaired similar misbehaviors for some other data types). Fixing it is pretty easy: just remove the special case and let the default code path handle these types. We could have kept the special case for BIT only, but there seems little point in that. Like the previous patch, I judge that back-patching this into stable branches wouldn't be a good idea. However, it seems not quite too late for v11, so let's fix it there. Paul Guo, reviewed by Davy Machado and John Naylor, minor adjustments by me Discussion: https://postgr.es/m/CABQrizdTra=2JEqA6+Ms1D1k1Kqw+aiBBhC9TreuZRX2JzxLAA@mail.gmail.com		2018-09-11 16:32:26 -04:00
..
backend	Remove ruleutils.c's special case for BIT [VARYING] literals.	2018-09-11 16:32:26 -04:00
bin	Avoid using potentially-under-aligned page buffers.	2018-09-01 15:27:13 -04:00
common	Minor cleanup/future-proofing for pg_saslprep().	2018-09-08 18:20:36 -04:00
fe_utils	Fix lexing of standard multi-character operators in edge cases.	2018-08-23 21:43:51 +01:00
include	Save/restore SPI's global variables in SPI_connect() and SPI_finish().	2018-09-07 20:09:57 -04:00
interfaces	Minor cleanup/future-proofing for pg_saslprep().	2018-09-08 18:20:36 -04:00
makefiles	Refactor installation of extension headers.	2018-09-07 14:30:15 +01:00
pl	Fix snapshot leak warning for some procedures	2018-08-27 22:15:39 +02:00
port	Make snprintf.c follow the C99 standard for snprintf's result value.	2018-08-15 17:25:49 -04:00
template	Force "restrict" not to be used when compiling with xlc.	2017-10-13 12:15:06 -07:00
test	Remove ruleutils.c's special case for BIT [VARYING] literals.	2018-09-11 16:32:26 -04:00
timezone	Update time zone data files to tzdata release 2018e.	2018-05-09 13:56:22 -04:00
tools	MSVC: Finish clean.bat tmp_check coverage.	2018-08-19 01:12:25 -07:00
tutorial	Update copyright for 2018	2018-01-02 23:30:12 -05:00
.gitignore
DEVELOPERS
Makefile	Fix partial-build problems introduced by having more generated headers.	2018-04-09 16:42:10 -04:00
Makefile.global.in	Ensure we build generated headers at the start of some more cases.	2018-07-30 18:04:39 -04:00
Makefile.shlib	Use -Bsymbolic for shared libraries on HP-UX and Solaris.	2018-09-10 22:22:12 -04:00
nls-global.mk	nls-global.mk: search build dir for source files, too	2016-06-07 18:55:18 -04:00