mirror of
https://github.com/postgres/postgres.git
synced 2026-04-27 09:07:42 -04:00
247dea89f7
If there are subqueries in the grouping expressions, each of these subqueries in the targetlist and HAVING clause is expanded into distinct SubPlan nodes. As a result, only one of these SubPlan nodes would be converted to reference to the grouping key column output by the Agg node; others would have to get evaluated afresh. This is not efficient, and with grouping sets this can cause wrong results issues in cases where they should go to NULL because they are from the wrong grouping set. Furthermore, during re-evaluation, these SubPlan nodes might use nulled column values from grouping sets, which is not correct. This issue is not limited to subqueries. For other types of expressions that are part of grouping items, if they are transformed into another form during preprocessing, they may fail to match lower target items. This can also lead to wrong results with grouping sets. To fix this issue, we introduce a new kind of RTE representing the output of the grouping step, with columns that are the Vars or expressions being grouped on. In the parser, we replace the grouping expressions in the targetlist and HAVING clause with Vars referencing this new RTE, so that the output of the parser directly expresses the semantic requirement that the grouping expressions be gotten from the grouping output rather than computed some other way. In the planner, we first preprocess all the columns of this new RTE and then replace any Vars in the targetlist and HAVING clause that reference this new RTE with the underlying grouping expressions, so that we will have only one instance of a SubPlan node for each subquery contained in the grouping expressions. Bump catversion because this changes the querytree produced by the parser. Thanks to Tom Lane for the idea to invent a new kind of RTE. Per reports from Geoff Winkless, Tobias Wendorff, Richard Guo from various threads. Author: Richard Guo Reviewed-by: Ashutosh Bapat, Sutou Kouhei Discussion: https://postgr.es/m/CAMbWs4_dp7e7oTwaiZeBX8+P1rXw4ThkZxh1QG81rhu9Z47VsQ@mail.gmail.com |
||
|---|---|---|
| .. | ||
| alter.h | ||
| async.h | ||
| cluster.h | ||
| collationcmds.h | ||
| comment.h | ||
| conversioncmds.h | ||
| copy.h | ||
| copyfrom_internal.h | ||
| createas.h | ||
| dbcommands.h | ||
| dbcommands_xlog.h | ||
| defrem.h | ||
| discard.h | ||
| event_trigger.h | ||
| explain.h | ||
| extension.h | ||
| lockcmds.h | ||
| matview.h | ||
| policy.h | ||
| portalcmds.h | ||
| prepare.h | ||
| proclang.h | ||
| progress.h | ||
| publicationcmds.h | ||
| schemacmds.h | ||
| seclabel.h | ||
| sequence.h | ||
| subscriptioncmds.h | ||
| tablecmds.h | ||
| tablespace.h | ||
| trigger.h | ||
| typecmds.h | ||
| user.h | ||
| vacuum.h | ||
| view.h | ||
| waitlsn.h | ||