mirror of
https://github.com/postgres/postgres.git
synced 2026-03-10 02:01:23 -04:00
If there are subqueries in the grouping expressions, each of these subqueries in the targetlist and HAVING clause is expanded into distinct SubPlan nodes. As a result, only one of these SubPlan nodes would be converted to reference to the grouping key column output by the Agg node; others would have to get evaluated afresh. This is not efficient, and with grouping sets this can cause wrong results issues in cases where they should go to NULL because they are from the wrong grouping set. Furthermore, during re-evaluation, these SubPlan nodes might use nulled column values from grouping sets, which is not correct. This issue is not limited to subqueries. For other types of expressions that are part of grouping items, if they are transformed into another form during preprocessing, they may fail to match lower target items. This can also lead to wrong results with grouping sets. To fix this issue, we introduce a new kind of RTE representing the output of the grouping step, with columns that are the Vars or expressions being grouped on. In the parser, we replace the grouping expressions in the targetlist and HAVING clause with Vars referencing this new RTE, so that the output of the parser directly expresses the semantic requirement that the grouping expressions be gotten from the grouping output rather than computed some other way. In the planner, we first preprocess all the columns of this new RTE and then replace any Vars in the targetlist and HAVING clause that reference this new RTE with the underlying grouping expressions, so that we will have only one instance of a SubPlan node for each subquery contained in the grouping expressions. Bump catversion because this changes the querytree produced by the parser. Thanks to Tom Lane for the idea to invent a new kind of RTE. Per reports from Geoff Winkless, Tobias Wendorff, Richard Guo from various threads. Author: Richard Guo Reviewed-by: Ashutosh Bapat, Sutou Kouhei Discussion: https://postgr.es/m/CAMbWs4_dp7e7oTwaiZeBX8+P1rXw4ThkZxh1QG81rhu9Z47VsQ@mail.gmail.com
224 lines
7.5 KiB
C
224 lines
7.5 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* nodeFuncs.h
|
|
* Various general-purpose manipulations of Node trees
|
|
*
|
|
* Portions Copyright (c) 1996-2024, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/nodes/nodeFuncs.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef NODEFUNCS_H
|
|
#define NODEFUNCS_H
|
|
|
|
#include "nodes/parsenodes.h"
|
|
|
|
struct PlanState; /* avoid including execnodes.h too */
|
|
|
|
|
|
/* flags bits for query_tree_walker and query_tree_mutator */
|
|
#define QTW_IGNORE_RT_SUBQUERIES 0x01 /* subqueries in rtable */
|
|
#define QTW_IGNORE_CTE_SUBQUERIES 0x02 /* subqueries in cteList */
|
|
#define QTW_IGNORE_RC_SUBQUERIES 0x03 /* both of above */
|
|
#define QTW_IGNORE_JOINALIASES 0x04 /* JOIN alias var lists */
|
|
#define QTW_IGNORE_RANGE_TABLE 0x08 /* skip rangetable entirely */
|
|
#define QTW_EXAMINE_RTES_BEFORE 0x10 /* examine RTE nodes before their
|
|
* contents */
|
|
#define QTW_EXAMINE_RTES_AFTER 0x20 /* examine RTE nodes after their
|
|
* contents */
|
|
#define QTW_DONT_COPY_QUERY 0x40 /* do not copy top Query */
|
|
#define QTW_EXAMINE_SORTGROUP 0x80 /* include SortGroupClause lists */
|
|
|
|
#define QTW_IGNORE_GROUPEXPRS 0x100 /* GROUP expressions list */
|
|
|
|
/* callback function for check_functions_in_node */
|
|
typedef bool (*check_function_callback) (Oid func_id, void *context);
|
|
|
|
/* callback functions for tree walkers */
|
|
typedef bool (*tree_walker_callback) (Node *node, void *context);
|
|
typedef bool (*planstate_tree_walker_callback) (struct PlanState *planstate,
|
|
void *context);
|
|
|
|
/* callback functions for tree mutators */
|
|
typedef Node *(*tree_mutator_callback) (Node *node, void *context);
|
|
|
|
|
|
extern Oid exprType(const Node *expr);
|
|
extern int32 exprTypmod(const Node *expr);
|
|
extern bool exprIsLengthCoercion(const Node *expr, int32 *coercedTypmod);
|
|
extern Node *applyRelabelType(Node *arg, Oid rtype, int32 rtypmod, Oid rcollid,
|
|
CoercionForm rformat, int rlocation,
|
|
bool overwrite_ok);
|
|
extern Node *relabel_to_typmod(Node *expr, int32 typmod);
|
|
extern Node *strip_implicit_coercions(Node *node);
|
|
extern bool expression_returns_set(Node *clause);
|
|
|
|
extern Oid exprCollation(const Node *expr);
|
|
extern Oid exprInputCollation(const Node *expr);
|
|
extern void exprSetCollation(Node *expr, Oid collation);
|
|
extern void exprSetInputCollation(Node *expr, Oid inputcollation);
|
|
|
|
extern int exprLocation(const Node *expr);
|
|
|
|
extern void fix_opfuncids(Node *node);
|
|
extern void set_opfuncid(OpExpr *opexpr);
|
|
extern void set_sa_opfuncid(ScalarArrayOpExpr *opexpr);
|
|
|
|
/* Is clause a FuncExpr clause? */
|
|
static inline bool
|
|
is_funcclause(const void *clause)
|
|
{
|
|
return clause != NULL && IsA(clause, FuncExpr);
|
|
}
|
|
|
|
/* Is clause an OpExpr clause? */
|
|
static inline bool
|
|
is_opclause(const void *clause)
|
|
{
|
|
return clause != NULL && IsA(clause, OpExpr);
|
|
}
|
|
|
|
/* Extract left arg of a binary opclause, or only arg of a unary opclause */
|
|
static inline Node *
|
|
get_leftop(const void *clause)
|
|
{
|
|
const OpExpr *expr = (const OpExpr *) clause;
|
|
|
|
if (expr->args != NIL)
|
|
return (Node *) linitial(expr->args);
|
|
else
|
|
return NULL;
|
|
}
|
|
|
|
/* Extract right arg of a binary opclause (NULL if it's a unary opclause) */
|
|
static inline Node *
|
|
get_rightop(const void *clause)
|
|
{
|
|
const OpExpr *expr = (const OpExpr *) clause;
|
|
|
|
if (list_length(expr->args) >= 2)
|
|
return (Node *) lsecond(expr->args);
|
|
else
|
|
return NULL;
|
|
}
|
|
|
|
/* Is clause an AND clause? */
|
|
static inline bool
|
|
is_andclause(const void *clause)
|
|
{
|
|
return (clause != NULL &&
|
|
IsA(clause, BoolExpr) &&
|
|
((const BoolExpr *) clause)->boolop == AND_EXPR);
|
|
}
|
|
|
|
/* Is clause an OR clause? */
|
|
static inline bool
|
|
is_orclause(const void *clause)
|
|
{
|
|
return (clause != NULL &&
|
|
IsA(clause, BoolExpr) &&
|
|
((const BoolExpr *) clause)->boolop == OR_EXPR);
|
|
}
|
|
|
|
/* Is clause a NOT clause? */
|
|
static inline bool
|
|
is_notclause(const void *clause)
|
|
{
|
|
return (clause != NULL &&
|
|
IsA(clause, BoolExpr) &&
|
|
((const BoolExpr *) clause)->boolop == NOT_EXPR);
|
|
}
|
|
|
|
/* Extract argument from a clause known to be a NOT clause */
|
|
static inline Expr *
|
|
get_notclausearg(const void *notclause)
|
|
{
|
|
return (Expr *) linitial(((const BoolExpr *) notclause)->args);
|
|
}
|
|
|
|
extern bool check_functions_in_node(Node *node, check_function_callback checker,
|
|
void *context);
|
|
|
|
/*
|
|
* The following functions are usually passed walker or mutator callbacks
|
|
* that are declared like "bool walker(Node *node, my_struct *context)"
|
|
* rather than "bool walker(Node *node, void *context)" as a strict reading
|
|
* of the C standard would require. Changing the callbacks' declarations
|
|
* to "void *" would create serious hazards of passing them the wrong context
|
|
* struct type, so we respectfully decline to support the standard's position
|
|
* that a pointer to struct is incompatible with "void *". Instead, silence
|
|
* related compiler warnings by inserting casts into these macro wrappers.
|
|
*/
|
|
|
|
#define expression_tree_walker(n, w, c) \
|
|
expression_tree_walker_impl(n, (tree_walker_callback) (w), c)
|
|
#define expression_tree_mutator(n, m, c) \
|
|
expression_tree_mutator_impl(n, (tree_mutator_callback) (m), c)
|
|
|
|
#define query_tree_walker(q, w, c, f) \
|
|
query_tree_walker_impl(q, (tree_walker_callback) (w), c, f)
|
|
#define query_tree_mutator(q, m, c, f) \
|
|
query_tree_mutator_impl(q, (tree_mutator_callback) (m), c, f)
|
|
|
|
#define range_table_walker(rt, w, c, f) \
|
|
range_table_walker_impl(rt, (tree_walker_callback) (w), c, f)
|
|
#define range_table_mutator(rt, m, c, f) \
|
|
range_table_mutator_impl(rt, (tree_mutator_callback) (m), c, f)
|
|
|
|
#define range_table_entry_walker(r, w, c, f) \
|
|
range_table_entry_walker_impl(r, (tree_walker_callback) (w), c, f)
|
|
|
|
#define query_or_expression_tree_walker(n, w, c, f) \
|
|
query_or_expression_tree_walker_impl(n, (tree_walker_callback) (w), c, f)
|
|
#define query_or_expression_tree_mutator(n, m, c, f) \
|
|
query_or_expression_tree_mutator_impl(n, (tree_mutator_callback) (m), c, f)
|
|
|
|
#define raw_expression_tree_walker(n, w, c) \
|
|
raw_expression_tree_walker_impl(n, (tree_walker_callback) (w), c)
|
|
|
|
#define planstate_tree_walker(ps, w, c) \
|
|
planstate_tree_walker_impl(ps, (planstate_tree_walker_callback) (w), c)
|
|
|
|
extern bool expression_tree_walker_impl(Node *node,
|
|
tree_walker_callback walker,
|
|
void *context);
|
|
extern Node *expression_tree_mutator_impl(Node *node,
|
|
tree_mutator_callback mutator,
|
|
void *context);
|
|
|
|
extern bool query_tree_walker_impl(Query *query,
|
|
tree_walker_callback walker,
|
|
void *context, int flags);
|
|
extern Query *query_tree_mutator_impl(Query *query,
|
|
tree_mutator_callback mutator,
|
|
void *context, int flags);
|
|
|
|
extern bool range_table_walker_impl(List *rtable,
|
|
tree_walker_callback walker,
|
|
void *context, int flags);
|
|
extern List *range_table_mutator_impl(List *rtable,
|
|
tree_mutator_callback mutator,
|
|
void *context, int flags);
|
|
|
|
extern bool range_table_entry_walker_impl(RangeTblEntry *rte,
|
|
tree_walker_callback walker,
|
|
void *context, int flags);
|
|
|
|
extern bool query_or_expression_tree_walker_impl(Node *node,
|
|
tree_walker_callback walker,
|
|
void *context, int flags);
|
|
extern Node *query_or_expression_tree_mutator_impl(Node *node,
|
|
tree_mutator_callback mutator,
|
|
void *context, int flags);
|
|
|
|
extern bool raw_expression_tree_walker_impl(Node *node,
|
|
tree_walker_callback walker,
|
|
void *context);
|
|
|
|
extern bool planstate_tree_walker_impl(struct PlanState *planstate,
|
|
planstate_tree_walker_callback walker,
|
|
void *context);
|
|
|
|
#endif /* NODEFUNCS_H */
|