mirror of
https://github.com/postgres/postgres.git
synced 2026-06-28 09:51:28 -04:00
SPI_commit previously left it up to the caller to recover from any error
occurring during commit. Since that's complicated and requires use of
low-level xact.c facilities, it's not too surprising that no caller got
it right. Let's move the responsibility for cleanup into spi.c. Doing
that requires redefining SPI_commit as starting a new transaction, so
that it becomes equivalent to SPI_commit_and_chain except that you get
default transaction characteristics instead of preserving the prior
transaction's characteristics. We can make this pretty transparent
API-wise by redefining SPI_start_transaction() as a no-op. Callers
that expect to do something in between might be surprised, but
available evidence is that no callers do so.
Having made that API redefinition, we can fix this mess by having
SPI_commit[_and_chain] trap errors and start a new, clean transaction
before re-throwing the error. Likewise for SPI_rollback[_and_chain].
Some cleanup is also needed in AtEOXact_SPI, which was nowhere near
smart enough to deal with SPI contexts nested inside a committing
context.
While plperl and pltcl need no changes beyond removing their now-useless
SPI_start_transaction() calls, plpython needs some more work because it
hadn't gotten the memo about catching commit/rollback errors in the
first place. Such an error resulted in longjmp'ing out of the Python
interpreter, which leaks Python stack entries at present and is reported
to crash Python 3.11 altogether. Add the missing logic to catch such
errors and convert them into Python exceptions.
This is a back-patch of commit 2e517818f. That's now aged long enough
to reduce the concerns about whether it will break something, and we
do need to ensure that supported branches will work with Python 3.11.
Peter Eisentraut and Tom Lane
Discussion: https://postgr.es/m/3375ffd8-d71c-2565-e348-a597d6e739e3@enterprisedb.com
Discussion: https://postgr.es/m/17416-ed8fe5d7213d6c25@postgresql.org
195 lines
3.6 KiB
PL/PgSQL
195 lines
3.6 KiB
PL/PgSQL
CREATE TABLE test1 (a int, b text);
|
|
|
|
|
|
CREATE PROCEDURE transaction_test1()
|
|
LANGUAGE plperl
|
|
AS $$
|
|
foreach my $i (0..9) {
|
|
spi_exec_query("INSERT INTO test1 (a) VALUES ($i)");
|
|
if ($i % 2 == 0) {
|
|
spi_commit();
|
|
} else {
|
|
spi_rollback();
|
|
}
|
|
}
|
|
$$;
|
|
|
|
CALL transaction_test1();
|
|
|
|
SELECT * FROM test1;
|
|
|
|
|
|
TRUNCATE test1;
|
|
|
|
DO
|
|
LANGUAGE plperl
|
|
$$
|
|
foreach my $i (0..9) {
|
|
spi_exec_query("INSERT INTO test1 (a) VALUES ($i)");
|
|
if ($i % 2 == 0) {
|
|
spi_commit();
|
|
} else {
|
|
spi_rollback();
|
|
}
|
|
}
|
|
$$;
|
|
|
|
SELECT * FROM test1;
|
|
|
|
|
|
TRUNCATE test1;
|
|
|
|
-- not allowed in a function
|
|
CREATE FUNCTION transaction_test2() RETURNS int
|
|
LANGUAGE plperl
|
|
AS $$
|
|
foreach my $i (0..9) {
|
|
spi_exec_query("INSERT INTO test1 (a) VALUES ($i)");
|
|
if ($i % 2 == 0) {
|
|
spi_commit();
|
|
} else {
|
|
spi_rollback();
|
|
}
|
|
}
|
|
return 1;
|
|
$$;
|
|
|
|
SELECT transaction_test2();
|
|
|
|
SELECT * FROM test1;
|
|
|
|
|
|
-- also not allowed if procedure is called from a function
|
|
CREATE FUNCTION transaction_test3() RETURNS int
|
|
LANGUAGE plperl
|
|
AS $$
|
|
spi_exec_query("CALL transaction_test1()");
|
|
return 1;
|
|
$$;
|
|
|
|
SELECT transaction_test3();
|
|
|
|
SELECT * FROM test1;
|
|
|
|
|
|
-- DO block inside function
|
|
CREATE FUNCTION transaction_test4() RETURNS int
|
|
LANGUAGE plperl
|
|
AS $$
|
|
spi_exec_query('DO LANGUAGE plperl $x$ spi_commit(); $x$');
|
|
return 1;
|
|
$$;
|
|
|
|
SELECT transaction_test4();
|
|
|
|
|
|
-- commit inside cursor loop
|
|
CREATE TABLE test2 (x int);
|
|
INSERT INTO test2 VALUES (0), (1), (2), (3), (4);
|
|
|
|
TRUNCATE test1;
|
|
|
|
DO LANGUAGE plperl $$
|
|
my $sth = spi_query("SELECT * FROM test2 ORDER BY x");
|
|
my $row;
|
|
while (defined($row = spi_fetchrow($sth))) {
|
|
spi_exec_query("INSERT INTO test1 (a) VALUES (" . $row->{x} . ")");
|
|
spi_commit();
|
|
}
|
|
$$;
|
|
|
|
SELECT * FROM test1;
|
|
|
|
-- check that this doesn't leak a holdable portal
|
|
SELECT * FROM pg_cursors;
|
|
|
|
|
|
-- error in cursor loop with commit
|
|
TRUNCATE test1;
|
|
|
|
DO LANGUAGE plperl $$
|
|
my $sth = spi_query("SELECT * FROM test2 ORDER BY x");
|
|
my $row;
|
|
while (defined($row = spi_fetchrow($sth))) {
|
|
spi_exec_query("INSERT INTO test1 (a) VALUES (12/(" . $row->{x} . "-2))");
|
|
spi_commit();
|
|
}
|
|
$$;
|
|
|
|
SELECT * FROM test1;
|
|
|
|
SELECT * FROM pg_cursors;
|
|
|
|
|
|
-- rollback inside cursor loop
|
|
TRUNCATE test1;
|
|
|
|
DO LANGUAGE plperl $$
|
|
my $sth = spi_query("SELECT * FROM test2 ORDER BY x");
|
|
my $row;
|
|
while (defined($row = spi_fetchrow($sth))) {
|
|
spi_exec_query("INSERT INTO test1 (a) VALUES (" . $row->{x} . ")");
|
|
spi_rollback();
|
|
}
|
|
$$;
|
|
|
|
SELECT * FROM test1;
|
|
|
|
SELECT * FROM pg_cursors;
|
|
|
|
|
|
-- first commit then rollback inside cursor loop
|
|
TRUNCATE test1;
|
|
|
|
DO LANGUAGE plperl $$
|
|
my $sth = spi_query("SELECT * FROM test2 ORDER BY x");
|
|
my $row;
|
|
while (defined($row = spi_fetchrow($sth))) {
|
|
spi_exec_query("INSERT INTO test1 (a) VALUES (" . $row->{x} . ")");
|
|
if ($row->{x} % 2 == 0) {
|
|
spi_commit();
|
|
} else {
|
|
spi_rollback();
|
|
}
|
|
}
|
|
$$;
|
|
|
|
SELECT * FROM test1;
|
|
|
|
SELECT * FROM pg_cursors;
|
|
|
|
|
|
-- check handling of an error during COMMIT
|
|
CREATE TABLE testpk (id int PRIMARY KEY);
|
|
CREATE TABLE testfk(f1 int REFERENCES testpk DEFERRABLE INITIALLY DEFERRED);
|
|
|
|
DO LANGUAGE plperl $$
|
|
# this insert will fail during commit:
|
|
spi_exec_query("INSERT INTO testfk VALUES (0)");
|
|
spi_commit();
|
|
elog(WARNING, 'should not get here');
|
|
$$;
|
|
|
|
SELECT * FROM testpk;
|
|
SELECT * FROM testfk;
|
|
|
|
DO LANGUAGE plperl $$
|
|
# this insert will fail during commit:
|
|
spi_exec_query("INSERT INTO testfk VALUES (0)");
|
|
eval {
|
|
spi_commit();
|
|
};
|
|
if ($@) {
|
|
elog(INFO, $@);
|
|
}
|
|
# these inserts should work:
|
|
spi_exec_query("INSERT INTO testpk VALUES (1)");
|
|
spi_exec_query("INSERT INTO testfk VALUES (1)");
|
|
$$;
|
|
|
|
SELECT * FROM testpk;
|
|
SELECT * FROM testfk;
|
|
|
|
|
|
DROP TABLE test1;
|
|
DROP TABLE test2;
|