postgresql/src/port
Tom Lane 0de9560ba9 Fix detection and handling of strchrnul() for macOS 15.4.
As of 15.4, macOS has strchrnul(), but access to it is blocked behind
a check for MACOSX_DEPLOYMENT_TARGET >= 15.4.  But our does-it-link
configure check finds it, so we try to use it, and fail with the
present default deployment target (namely 15.0).  This accounts for
today's buildfarm failures on indri and sifaka.

This is the identical problem that we faced some years ago when Apple
introduced preadv and pwritev in the same way.  We solved that in
commit f014b1b9b by using AC_CHECK_DECLS instead of AC_CHECK_FUNCS
to check the functions' availability.  So do the same now for
strchrnul().  Interestingly, we already had a workaround for
"the link check doesn't agree with <string.h>" cases with glibc,
which we no longer need since only the header declaration is being
checked.

Testing this revealed that the meson version of this check has never
worked, because it failed to use "-Werror=unguarded-availability-new".
(Apparently nobody's tried to build with meson on macOS versions that
lack preadv/pwritev as standard.)  Adjust that while at it.  Also,
we had never put support for "-Werror=unguarded-availability-new"
into v13, but we need that now.

Co-authored-by: Tom Lane <tgl@sss.pgh.pa.us>
Co-authored-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/385134.1743523038@sss.pgh.pa.us
Backpatch-through: 13
2025-04-01 16:49:51 -04:00
..
.gitignore Build src/port files as a library with -fPIC, and use that in libpq. 2018-09-27 11:23:43 -04:00
bsearch_arg.c Fix overflow in bsearch_arg() with more than INT_MAX elements 2024-10-28 14:08:00 +02:00
chklocale.c Remove extraneous blank lines before block-closing braces 2022-04-13 19:16:02 +02:00
dirent.c Fix get_dirent_type() for Windows junction points. 2022-07-22 16:57:36 +12:00
dirmod.c Fix readlink() for non-PostgreSQL junction points on Windows. 2025-01-18 09:31:39 -05:00
dlopen.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
explicit_bzero.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
fls.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
getaddrinfo.c Clean up messy API for src/port/thread.c. 2022-01-11 13:46:20 -05:00
getopt.c Use our own getopt() on OpenBSD. 2019-01-18 15:06:26 -05:00
getopt_long.c Fix our getopt_long's behavior for a command line argument of just "-". 2020-03-23 11:58:00 -04:00
getpeereid.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
getrusage.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
gettimeofday.c Clean up newlines following left parentheses 2020-01-30 13:42:14 -03:00
inet_aton.c Correct include file name in inet_aton fallback. 2017-10-01 17:41:00 -07:00
inet_net_ntop.c Avoid conflicts with library versions of inet_net_ntop() and friends. 2019-08-18 19:27:23 -04:00
kill.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
link.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
Makefile Clean up messy API for src/port/thread.c. 2022-01-11 13:46:20 -05:00
mkdtemp.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
noblock.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
open.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
path.c Avoid breaking SJIS encoding while de-backslashing Windows paths. 2025-01-29 14:24:36 -05:00
pg_bitutils.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pg_crc32c_armv8.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pg_crc32c_armv8_choose.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pg_crc32c_sb8.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pg_crc32c_sse42.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pg_crc32c_sse42_choose.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pg_strong_random.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pgcheckdir.c Fix various typos, grammar and code style in comments and docs 2022-01-25 09:40:04 +09:00
pgmkdirp.c Fix various typos and grammar errors in comments. 2015-04-26 18:42:31 +02:00
pgsleep.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pgstrcasecmp.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pgstrsignal.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pqsignal.c Avoid symbol collisions between pqsignal.c and legacy-pqsignal.c. 2025-01-14 18:50:24 -05:00
pread.c Include c.h instead of postgres.h in src/port/*p{read,write}*.c 2022-09-17 09:23:49 -07:00
preadv.c Include c.h instead of postgres.h in src/port/*p{read,write}*.c 2022-09-17 09:23:49 -07:00
pthread-win32.h Clean up Windows-specific mutex code in libpq and ecpglib. 2024-02-09 11:11:39 -05:00
pthread_barrier_wait.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pwrite.c Include c.h instead of postgres.h in src/port/*p{read,write}*.c 2022-09-17 09:23:49 -07:00
pwritev.c Include c.h instead of postgres.h in src/port/*p{read,write}*.c 2022-09-17 09:23:49 -07:00
qsort.c Use sort_template.h for qsort() and qsort_arg(). 2021-03-03 17:02:32 +13:00
qsort_arg.c Use sort_template.h for qsort() and qsort_arg(). 2021-03-03 17:02:32 +13:00
quotes.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
README AIX: Fix missing libpq symbols by respecting SHLIB_EXPORTS. 2021-09-06 11:27:59 -07:00
setenv.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
snprintf.c Fix detection and handling of strchrnul() for macOS 15.4. 2025-04-01 16:49:51 -04:00
strerror.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
strlcat.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
strlcpy.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
strnlen.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
strtof.c Fix pg_strtof() to not crash on NULL endptr. 2025-03-01 14:22:56 -05:00
system.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
tar.c Make the order of the header file includes consistent in non-backend modules. 2019-10-25 07:41:52 +05:30
thread.c Clean up messy API for src/port/thread.c. 2022-01-11 13:46:20 -05:00
unsetenv.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
win32.ico
win32common.c Fix detection of unseekable files for fseek() and ftello() with MSVC 2023-04-12 09:09:53 +09:00
win32env.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
win32error.c Fix lstat() for broken junction points on Windows. 2024-11-08 09:29:15 +10:30
win32fseek.c Fix detection of unseekable files for fseek() and ftello() with MSVC 2023-04-12 09:09:53 +09:00
win32ntdll.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
win32security.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
win32setlocale.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
win32stat.c Fix stat() for recursive junction points on Windows. 2025-01-18 09:30:10 -05:00
win32ver.rc Update copyright for 2022 2022-01-07 19:04:57 -05:00

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter strlcat.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Windows, Linux, AIX, and macOS use an export
list to control the symbols exported by libpq.