postgresql/contrib/pgcrypto
Noah Misch e5981aebde pgcrypto: Report errant decryption as "Wrong key or corrupt data".
This has been the predominant outcome.  When the output of decrypting
with a wrong key coincidentally resembled an OpenPGP packet header,
pgcrypto could instead report "Corrupt data", "Not text data" or
"Unsupported compression algorithm".  The distinct "Corrupt data"
message added no value.  The latter two error messages misled when the
decrypted payload also exhibited fundamental integrity problems.  Worse,
error message variance in other systems has enabled cryptologic attacks;
see RFC 4880 section "14. Security Considerations".  Whether these
pgcrypto behaviors are likewise exploitable is unknown.

In passing, document that pgcrypto does not resist side-channel attacks.
Back-patch to 9.0 (all supported versions).

Security: CVE-2015-3167
2015-05-18 10:02:38 -04:00
..
expected pgcrypto: Report errant decryption as "Wrong key or corrupt data". 2015-05-18 10:02:38 -04:00
sql pgcrypto: Report errant decryption as "Wrong key or corrupt data". 2015-05-18 10:02:38 -04:00
.gitignore Support "make check" in contrib 2011-04-25 22:27:11 +03:00
blf.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
blf.h Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
crypt-blowfish.c pgcrypto: fix memset() calls that might be optimized away 2014-04-17 12:37:53 -04:00
crypt-des.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
crypt-gensalt.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
crypt-md5.c pgcrypto: fix memset() calls that might be optimized away 2014-04-17 12:37:53 -04:00
fortuna.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
fortuna.h Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
imath.c Cherry-pick security-relevant fixes from upstream imath library. 2015-02-02 10:00:52 -05:00
imath.h Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
internal-sha2.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
internal.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
Makefile Convert contrib modules to use the extension facility. 2011-02-13 22:54:49 -05:00
mbuf.c pgcrypto: Report errant decryption as "Wrong key or corrupt data". 2015-05-18 10:02:38 -04:00
mbuf.h Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
md5.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
md5.h Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
openssl.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgcrypto--1.0.sql Throw a useful error message if an extension script file is fed to psql. 2011-10-12 15:45:36 -04:00
pgcrypto--unpackaged--1.0.sql Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:53 +02:00
pgcrypto.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgcrypto.control Convert contrib modules to use the extension facility. 2011-02-13 22:54:49 -05:00
pgcrypto.h Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgp-armor.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgp-cfb.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgp-compress.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgp-decrypt.c pgcrypto: Report errant decryption as "Wrong key or corrupt data". 2015-05-18 10:02:38 -04:00
pgp-encrypt.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgp-info.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgp-mpi-internal.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgp-mpi-openssl.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgp-mpi.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgp-pgsql.c Docs: fix incorrect spelling of contrib/pgcrypto option. 2014-11-03 11:11:55 -05:00
pgp-pubdec.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgp-pubenc.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgp-pubkey.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgp-s2k.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgp.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
pgp.h pgcrypto: Report errant decryption as "Wrong key or corrupt data". 2015-05-18 10:02:38 -04:00
px-crypt.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
px-crypt.h Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
px-hmac.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
px.c pgcrypto: Report errant decryption as "Wrong key or corrupt data". 2015-05-18 10:02:38 -04:00
px.h pgcrypto: Report errant decryption as "Wrong key or corrupt data". 2015-05-18 10:02:38 -04:00
random.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
rijndael.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
rijndael.h Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
rijndael.tbl Remove useless whitespace at end of lines 2010-11-23 22:34:55 +02:00
sha1.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
sha1.h Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
sha2.c Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00
sha2.h Remove tabs after spaces in C comments 2014-05-06 11:26:26 -04:00