mirror of
https://github.com/postgres/postgres.git
synced 2026-04-21 14:19:26 -04:00
599336c64f
When running in Docker, the container may not have privileges needed by
get_mempolicy(). This is called by numa_available() in libnuma, but
versions prior to 2.0.19 did not expect that. The numa_available() call
seemingly succeeds, but then we get unexpected failures when trying to
query status of pages:
postgres =# select * from pg_shmem_allocations_numa;
ERROR: XX000: failed NUMA pages inquiry status: Operation not
permitted
LOCATION: pg_get_shmem_allocations_numa, shmem.c:691
The best solution is to call get_mempolicy() first, and proceed to
numa_available() only when it does not fail with EPERM. Otherwise we'd
need to treat older libnuma versions as insufficient, which seems a bit
too harsh, as this only affects containerized systems.
Fix by me, based on suggestions by Christoph. Backpatch to 18, where the
NUMA functions were introduced.
Reported-by: Christoph Berg <myon@debian.org>
Reviewed-by: Christoph Berg <myon@debian.org>
Discussion: https://postgr.es/m/aPDZOxjrmEo_1JRG@msg.df7cb.de
Backpatch-through: 18
|
||
|---|---|---|
| .. | ||
| .gitignore | ||
| bsearch_arg.c | ||
| chklocale.c | ||
| dirent.c | ||
| dirmod.c | ||
| explicit_bzero.c | ||
| getopt.c | ||
| getopt_long.c | ||
| getpeereid.c | ||
| inet_aton.c | ||
| inet_net_ntop.c | ||
| kill.c | ||
| Makefile | ||
| meson.build | ||
| mkdtemp.c | ||
| noblock.c | ||
| open.c | ||
| path.c | ||
| pg_bitutils.c | ||
| pg_crc32c_armv8.c | ||
| pg_crc32c_armv8_choose.c | ||
| pg_crc32c_loongarch.c | ||
| pg_crc32c_sb8.c | ||
| pg_crc32c_sse42.c | ||
| pg_crc32c_sse42_choose.c | ||
| pg_localeconv_r.c | ||
| pg_numa.c | ||
| pg_popcount_aarch64.c | ||
| pg_popcount_avx512.c | ||
| pg_strong_random.c | ||
| pgcheckdir.c | ||
| pgmkdirp.c | ||
| pgsleep.c | ||
| pgstrcasecmp.c | ||
| pgstrsignal.c | ||
| pqsignal.c | ||
| pthread-win32.h | ||
| pthread_barrier_wait.c | ||
| qsort.c | ||
| qsort_arg.c | ||
| quotes.c | ||
| README | ||
| snprintf.c | ||
| strerror.c | ||
| strlcat.c | ||
| strlcpy.c | ||
| strnlen.c | ||
| strsep.c | ||
| strtof.c | ||
| system.c | ||
| tar.c | ||
| timingsafe_bcmp.c | ||
| win32.ico | ||
| win32common.c | ||
| win32dlopen.c | ||
| win32env.c | ||
| win32error.c | ||
| win32fdatasync.c | ||
| win32fseek.c | ||
| win32gai_strerror.c | ||
| win32getrusage.c | ||
| win32gettimeofday.c | ||
| win32link.c | ||
| win32ntdll.c | ||
| win32pread.c | ||
| win32pwrite.c | ||
| win32security.c | ||
| win32setlocale.c | ||
| win32stat.c | ||
| win32ver.rc | ||
src/port/README
libpgport
=========
libpgport must have special behavior. It supplies functions to both
libraries and applications. However, there are two complexities:
1) Libraries need to use object files that are compiled with exactly
the same flags as the library. libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries. This is done by removing -lpgport from the link line:
# Need to recompile any libpgport object files
LIBS := $(filter-out -lpgport, $(LIBS))
and adding infrastructure to recompile the object files:
OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
connect.o misc.o path.o exec.o \
$(filter strlcat.o, $(LIBOBJS))
The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.
2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first. This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq. libpq's libpgport usage changes over time, so such a
dependency is a problem. Windows, Linux, and macOS use an export
list to control the symbols exported by libpq.