mirror of
https://github.com/postgres/postgres.git
synced 2026-02-21 08:50:51 -05:00
2ec477dc81
It emerges that libreadline doesn't notice terminal window size change events unless they occur while collecting input. This is easy to stumble over if you resize the window while using a pager to look at query output, but it can be demonstrated without any pager involvement. The symptom is that queries exceeding one line are misdisplayed during subsequent input cycles, because libreadline has the wrong idea of the screen dimensions. The safest, simplest way to fix this is to call rl_reset_screen_size() just before calling readline(). That causes an extra ioctl(TIOCGWINSZ) for every command; but since it only happens when reading from a tty, the performance impact should be negligible. A more valid objection is that this still leaves a tiny window during entry to readline() wherein delivery of SIGWINCH will be missed; but the practical consequences of that are probably negligible. In any case, there doesn't seem to be any good way to avoid the race, since readline exposes no functions that seem safe to call from a generic signal handler --- rl_reset_screen_size() certainly isn't. It turns out that we also need an explicit rl_initialize() call, else rl_reset_screen_size() dumps core when called before the first readline() call. rl_reset_screen_size() is not present in old versions of libreadline, so we need a configure test for that. (rl_initialize() is present at least back to readline 4.0, so we won't bother with a test for it.) We would need a configure test anyway since libedit's emulation of libreadline doesn't currently include such a function. Fortunately, libedit seems not to have any corresponding bug. Merlin Moncure, adjusted a bit by me |
||
|---|---|---|
| .. | ||
| po | ||
| .gitignore | ||
| command.c | ||
| command.h | ||
| common.c | ||
| common.h | ||
| copy.c | ||
| copy.h | ||
| create_help.pl | ||
| describe.c | ||
| describe.h | ||
| help.c | ||
| help.h | ||
| input.c | ||
| input.h | ||
| large_obj.c | ||
| large_obj.h | ||
| mainloop.c | ||
| mainloop.h | ||
| Makefile | ||
| mbprint.c | ||
| mbprint.h | ||
| nls.mk | ||
| print.c | ||
| print.h | ||
| prompt.c | ||
| prompt.h | ||
| psqlrc.sample | ||
| psqlscan.h | ||
| psqlscan.l | ||
| settings.h | ||
| startup.c | ||
| stringutils.c | ||
| stringutils.h | ||
| tab-complete.c | ||
| tab-complete.h | ||
| variables.c | ||
| variables.h | ||