mirror of
https://github.com/postgres/postgres.git
synced 2026-02-12 23:33:27 -05:00
2f3304ce13
When creating and initializing a logical slot, the restart_lsn is set to the latest WAL insertion point (or the latest replay point on standbys). Subsequently, WAL records are decoded from that point to find the start point for extracting changes in the DecodingContextFindStartpoint() function. Since the initial restart_lsn could be in the middle of a transaction, the start point must be a consistent point where we won't see the data for partial transactions. Previously, when not building a full snapshot, serialized snapshots were restored, and the SnapBuild jumps to the consistent state even while finding the start point. Consequently, the slot's restart_lsn and confirmed_flush could be set to the middle of a transaction. This could lead to various unexpected consequences. Specifically, there were reports of logical decoding decoding partial transactions, and assertion failures occurred because only subtransactions were decoded without decoding their top-level transaction until decoding the commit record. To resolve this issue, the changes prevent restoring the serialized snapshot and jumping to the consistent state while finding the start point. On v17 and HEAD, a flag indicating whether snapshot restores should be skipped has been added to the SnapBuild struct, and SNAPBUILD_VERSION has been bumpded. On backbranches, the flag is stored in the LogicalDecodingContext instead, preserving on-disk compatibility. Backpatch to all supported versions. Reported-by: Drew Callahan Reviewed-by: Amit Kapila, Hayato Kuroda Discussion: https://postgr.es/m/2444AA15-D21B-4CCE-8052-52C7C2DAFE5C%40amazon.com Backpatch-through: 12 |
||
|---|---|---|
| .. | ||
| binary.out | ||
| catalog_change_snapshot.out | ||
| concurrent_ddl_dml.out | ||
| concurrent_stream.out | ||
| ddl.out | ||
| decoding_in_xact.out | ||
| decoding_into_rel.out | ||
| delayed_startup.out | ||
| messages.out | ||
| mxact.out | ||
| oldest_xmin.out | ||
| ondisk_startup.out | ||
| permissions.out | ||
| prepared.out | ||
| replorigin.out | ||
| rewrite.out | ||
| skip_snapshot_restore.out | ||
| slot.out | ||
| slot_creation_error.out | ||
| snapshot_transfer.out | ||
| spill.out | ||
| stats.out | ||
| stream.out | ||
| subxact_without_top.out | ||
| time.out | ||
| toast.out | ||
| truncate.out | ||
| twophase.out | ||
| twophase_snapshot.out | ||
| twophase_stream.out | ||
| xact.out | ||