mirror of
https://github.com/postgres/postgres.git
synced 2026-03-09 01:31:22 -04:00
3957b58b88
If inherited tables don't have exactly the same schema, the USING clause
in an ALTER TABLE / SET DATA TYPE misbehaves when applied to the
children tables since commit 9550e8348b. Starting with that commit,
the attribute numbers in the USING expression are fixed during parse
analysis. This can lead to bogus errors being reported during
execution, such as:
ERROR: attribute 2 has wrong type
DETAIL: Table has type smallint, but query expects integer.
Since it wouldn't do to revert to the original coding, we now apply a
transformation to map the attribute numbers to the correct ones for each
child.
Reported by Justin Pryzby
Analysis by Tom Lane; patch by me.
Discussion: https://postgr.es/m/20170102225618.GA10071@telsasoft.com
49 lines
1.4 KiB
C
49 lines
1.4 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* tupconvert.h
|
|
* Tuple conversion support.
|
|
*
|
|
*
|
|
* Portions Copyright (c) 1996-2017, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/access/tupconvert.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef TUPCONVERT_H
|
|
#define TUPCONVERT_H
|
|
|
|
#include "access/htup.h"
|
|
#include "access/tupdesc.h"
|
|
|
|
|
|
typedef struct TupleConversionMap
|
|
{
|
|
TupleDesc indesc; /* tupdesc for source rowtype */
|
|
TupleDesc outdesc; /* tupdesc for result rowtype */
|
|
AttrNumber *attrMap; /* indexes of input fields, or 0 for null */
|
|
Datum *invalues; /* workspace for deconstructing source */
|
|
bool *inisnull;
|
|
Datum *outvalues; /* workspace for constructing result */
|
|
bool *outisnull;
|
|
} TupleConversionMap;
|
|
|
|
|
|
extern TupleConversionMap *convert_tuples_by_position(TupleDesc indesc,
|
|
TupleDesc outdesc,
|
|
const char *msg);
|
|
|
|
extern TupleConversionMap *convert_tuples_by_name(TupleDesc indesc,
|
|
TupleDesc outdesc,
|
|
const char *msg);
|
|
|
|
extern AttrNumber *convert_tuples_by_name_map(TupleDesc indesc,
|
|
TupleDesc outdesc,
|
|
const char *msg);
|
|
|
|
extern HeapTuple do_convert_tuple(HeapTuple tuple, TupleConversionMap *map);
|
|
|
|
extern void free_conversion_map(TupleConversionMap *map);
|
|
|
|
#endif /* TUPCONVERT_H */
|