mirror of
https://github.com/postgres/postgres.git
synced 2026-02-11 06:43:59 -05:00
8c75ad436f
Previously, plpython was in the habit of allocating a lot of stuff in TopMemoryContext, and it was very slipshod about making sure that stuff got cleaned up; in particular, use of TopMemoryContext as fn_mcxt for function calls represents an unfixable leak, since we generally don't know what the called function might have allocated in fn_mcxt. This results in session-lifespan leakage in certain usage scenarios, as for example in a case reported by Ed Behn back in July. To fix, get rid of all the retail allocations in TopMemoryContext. All long-lived allocations are now made in sub-contexts that are associated with specific objects (either pl/python procedures, or Python-visible objects such as cursors and plans). We can clean these up when the associated object is deleted. I went so far as to get rid of PLy_malloc completely. There were a couple of places where it could still have been used safely, but on the whole it was just an invitation to bad coding. Haribabu Kommi, based on a draft patch by Heikki Linnakangas; some further work by me
17 lines
435 B
C
17 lines
435 B
C
/*--------------------------
|
|
* common utility functions
|
|
*--------------------------
|
|
*/
|
|
|
|
#ifndef PLPY_UTIL_H
|
|
#define PLPY_UTIL_H
|
|
|
|
extern PyObject *PLyUnicode_Bytes(PyObject *unicode);
|
|
extern char *PLyUnicode_AsString(PyObject *unicode);
|
|
|
|
#if PY_MAJOR_VERSION >= 3
|
|
extern PyObject *PLyUnicode_FromString(const char *s);
|
|
extern PyObject *PLyUnicode_FromStringAndSize(const char *s, Py_ssize_t size);
|
|
#endif
|
|
|
|
#endif /* PLPY_UTIL_H */
|