mirror of
https://github.com/postgres/postgres.git
synced 2026-02-24 02:11:28 -05:00
c7b8998ebb
Change pg_bsd_indent to follow upstream rules for placement of comments
to the right of code, and remove pgindent hack that caused comments
following #endif to not obey the general rule.
Commit e3860ffa4d wasn't actually using
the published version of pg_bsd_indent, but a hacked-up version that
tried to minimize the amount of movement of comments to the right of
code. The situation of interest is where such a comment has to be
moved to the right of its default placement at column 33 because there's
code there. BSD indent has always moved right in units of tab stops
in such cases --- but in the previous incarnation, indent was working
in 8-space tab stops, while now it knows we use 4-space tabs. So the
net result is that in about half the cases, such comments are placed
one tab stop left of before. This is better all around: it leaves
more room on the line for comment text, and it means that in such
cases the comment uniformly starts at the next 4-space tab stop after
the code, rather than sometimes one and sometimes two tabs after.
Also, ensure that comments following #endif are indented the same
as comments following other preprocessor commands such as #else.
That inconsistency turns out to have been self-inflicted damage
from a poorly-thought-through post-indent "fixup" in pgindent.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
75 lines
1.8 KiB
C
75 lines
1.8 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* walsender.h
|
|
* Exports from replication/walsender.c.
|
|
*
|
|
* Portions Copyright (c) 2010-2017, PostgreSQL Global Development Group
|
|
*
|
|
* src/include/replication/walsender.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef _WALSENDER_H
|
|
#define _WALSENDER_H
|
|
|
|
#include <signal.h>
|
|
|
|
#include "fmgr.h"
|
|
|
|
/*
|
|
* What to do with a snapshot in create replication slot command.
|
|
*/
|
|
typedef enum
|
|
{
|
|
CRS_EXPORT_SNAPSHOT,
|
|
CRS_NOEXPORT_SNAPSHOT,
|
|
CRS_USE_SNAPSHOT
|
|
} CRSSnapshotAction;
|
|
|
|
/* global state */
|
|
extern bool am_walsender;
|
|
extern bool am_cascading_walsender;
|
|
extern bool am_db_walsender;
|
|
extern bool wake_wal_senders;
|
|
|
|
/* user-settable parameters */
|
|
extern int max_wal_senders;
|
|
extern int wal_sender_timeout;
|
|
extern bool log_replication_commands;
|
|
|
|
extern void InitWalSender(void);
|
|
extern bool exec_replication_command(const char *query_string);
|
|
extern void WalSndErrorCleanup(void);
|
|
extern void WalSndSignals(void);
|
|
extern Size WalSndShmemSize(void);
|
|
extern void WalSndShmemInit(void);
|
|
extern void WalSndWakeup(void);
|
|
extern void WalSndInitStopping(void);
|
|
extern void WalSndWaitStopping(void);
|
|
extern void HandleWalSndInitStopping(void);
|
|
extern void WalSndRqstFileReload(void);
|
|
|
|
/*
|
|
* Remember that we want to wakeup walsenders later
|
|
*
|
|
* This is separated from doing the actual wakeup because the writeout is done
|
|
* while holding contended locks.
|
|
*/
|
|
#define WalSndWakeupRequest() \
|
|
do { wake_wal_senders = true; } while (0)
|
|
|
|
/*
|
|
* wakeup walsenders if there is work to be done
|
|
*/
|
|
#define WalSndWakeupProcessRequests() \
|
|
do \
|
|
{ \
|
|
if (wake_wal_senders) \
|
|
{ \
|
|
wake_wal_senders = false; \
|
|
if (max_wal_senders > 0) \
|
|
WalSndWakeup(); \
|
|
} \
|
|
} while (0)
|
|
|
|
#endif /* _WALSENDER_H */
|