mirror of
https://github.com/postgres/postgres.git
synced 2026-04-11 03:56:42 -04:00
d0054432d4
When a partitioned table has an index that doesn't support a constraint, but a partition has an equivalent index that does, then a DETACH operation would misbehave: a crash in assertion-enabled systems (because we fail to find the constraint in the parent that we expect to), or a broken coninhcount value (-1) in production systems (because we blindly believe that we've successfully detached the parent). While we should reject an ATTACH of a partition with such an index, we have failed to do so in existing releases, so adding an error in stable releases might break the (unlikely) existing applications that rely on this behavior. At this point I don't even want to reject them in master, because it'd break pg_upgrade if such databases exist, and there would be no easy way to fix existing databases without expensive index rebuilds. (Later on we could add ALTER TABLE ... ADD CONSTRAINT USING INDEX to partitioned tables, which would allow the user to fix such patterns. At that point we could add more restrictions to prevent the problem from its root.) Also, add a test case that leaves one table in this condition, so that we can verify that pg_upgrade continues to work if we later decide to change the policy on the master branch. Backpatch to all supported branches. Co-authored-by: Tender Wang <tndrwang@gmail.com> Reported-by: Alexander Lakhin <exclusion@gmail.com> Reviewed-by: Tender Wang <tndrwang@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/18500-62948b6fe5522f56@postgresql.org |
||
|---|---|---|
| .. | ||
| aggregatecmds.c | ||
| alter.c | ||
| amcmds.c | ||
| analyze.c | ||
| async.c | ||
| cluster.c | ||
| collationcmds.c | ||
| comment.c | ||
| constraint.c | ||
| conversioncmds.c | ||
| copy.c | ||
| createas.c | ||
| dbcommands.c | ||
| define.c | ||
| discard.c | ||
| dropcmds.c | ||
| event_trigger.c | ||
| explain.c | ||
| extension.c | ||
| foreigncmds.c | ||
| functioncmds.c | ||
| indexcmds.c | ||
| lockcmds.c | ||
| Makefile | ||
| matview.c | ||
| opclasscmds.c | ||
| operatorcmds.c | ||
| policy.c | ||
| portalcmds.c | ||
| prepare.c | ||
| proclang.c | ||
| publicationcmds.c | ||
| schemacmds.c | ||
| seclabel.c | ||
| sequence.c | ||
| statscmds.c | ||
| subscriptioncmds.c | ||
| tablecmds.c | ||
| tablespace.c | ||
| trigger.c | ||
| tsearchcmds.c | ||
| typecmds.c | ||
| user.c | ||
| vacuum.c | ||
| variable.c | ||
| view.c | ||