Michael Paquier de559c2b06 Switch pg_test_fsync to use binary mode on Windows ... pg_test_fsync has always opened files using the text mode on Windows, as this is the default mode used if not enforced by _setmode(). This fixes a failure when running pg_test_fsync down to 12 because O_DSYNC and the text mode are not able to work together nicely. We fixed the handling of O_DSYNC in 12~ for the tool by switching to the concurrent-safe version of fopen() in src/port/ with 0ba06e0. And 40cfe86, by enforcing the text mode for compatibility reasons if O_TEXT or O_BINARY are not specified by the caller, broke pg_test_fsync. For all versions, this avoids any translation overhead, and pg_test_fsync should test binary writes, so it is a gain in all cases. Note that O_DSYNC is still not handled correctly in ~11, leading to pg_test_fsync to show insanely high numbers for open_datasync() (using this property it is easy to notice that the binary mode is much faster). This would require a backpatch of 0ba06e0 and 40cfe86, which could potentially break existing applications, so this is left out. There are no TAP tests for this tool yet, so I have checked all builds manually using MSVC. We could invent a new option to run a single transaction instead of using a duration of 1s to make the tests a maximum short, but this is left as future work. Thanks to Bruce Momjian for the discussion. Reported-by: Jeff Janes Author: Michael Paquier Discussion: https://postgr.es/m/16526-279ded30a230d275@postgresql.org Backpatch-through: 9.5		2020-07-16 15:53:01 +09:00
..
po	Translation updates	2019-11-11 10:50:22 +01:00
.gitignore	Move pg_test_fsync from contrib/ to src/bin/	2015-04-19 22:20:49 -04:00
Makefile	Move pg_test_fsync from contrib/ to src/bin/	2015-04-19 22:20:49 -04:00
nls.mk	Translation updates	2019-11-11 10:50:22 +01:00
pg_test_fsync.c	Switch pg_test_fsync to use binary mode on Windows	2020-07-16 15:53:01 +09:00