mirror of
https://github.com/postgres/postgres.git
synced 2026-03-12 05:32:27 -04:00
afc7328457
If a CHECK constraint or index definition contained a whole-row Var (that is, "table.*"), an attempt to copy that definition via CREATE TABLE LIKE or table inheritance produced incorrect results: the copied Var still claimed to have the rowtype of the source table, rather than the created table. For the LIKE case, it seems reasonable to just throw error for this situation, since the point of LIKE is that the new table is not permanently coupled to the old, so there's no reason to assume its rowtype will stay compatible. In the inheritance case, we should ideally allow such constraints, but doing so will require nontrivial refactoring of CREATE TABLE processing (because we'd need to know the OID of the new table's rowtype before we adjust inherited CHECK constraints). In view of the lack of previous complaints, that doesn't seem worth the risk in a back-patched bug fix, so just make it throw error for the inheritance case as well. Along the way, replace change_varattnos_of_a_node() with a more robust function map_variable_attnos(), which is capable of being extended to handle insertion of ConvertRowtypeExpr whenever we get around to fixing the inheritance case nicely, and in the meantime it returns a failure indication to the caller so that a helpful message with some context can be thrown. Also, this code will do the right thing with subselects (if we ever allow them in CHECK or indexes), and it range-checks varattnos before using them to index into the map array. Per report from Sergey Konoplev. Back-patch to all supported branches. |
||
|---|---|---|
| .. | ||
| alter.h | ||
| async.h | ||
| cluster.h | ||
| comment.h | ||
| conversioncmds.h | ||
| copy.h | ||
| dbcommands.h | ||
| defrem.h | ||
| discard.h | ||
| explain.h | ||
| lockcmds.h | ||
| portalcmds.h | ||
| prepare.h | ||
| proclang.h | ||
| schemacmds.h | ||
| sequence.h | ||
| tablecmds.h | ||
| tablespace.h | ||
| trigger.h | ||
| typecmds.h | ||
| user.h | ||
| vacuum.h | ||
| variable.h | ||
| view.h | ||