upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-03-09 17:50:43 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
postgresql/contrib
History
Tom Lane 9b48ce3773 Further fix pg_trgm's extraction of trigrams from regular expressions. 
Commit 9e43e8714 turns out to have been insufficient: not only is it
necessary to track tentative parent links while considering a set of
arc removals, but it's necessary to track tentative flag additions
as well.  This is because we always merge arc target states into
arc source states; therefore, when considering a merge of the final
state with some other, it is the other state that will acquire a new
TSTATE_FIN bit.  If there's another arc for the same color trigram
that would cause merging of that state with the initial state, we
failed to recognize the problem.  The test cases for the prior commit
evidently only exercised situations where a tentative merge with the
initial state occurs before one with the final state.  If it goes the
other way around, we'll happily merge the initial and final states,
either producing a broken final graph that would never match anything,
or triggering the Assert added by the prior commit.

It's tempting to consider switching the merge direction when the merge
involves the final state, but I lack the time to analyze that idea in
detail.  Instead just keep track of the flag changes that would result
from proposed merges, in the same way that the prior commit tracked
proposed parent links.

Along the way, add some more debugging support, because I'm not entirely
confident that this is the last bug here.  And tweak matters so that
the transformed.dot file uses small integers rather than pointer values
to identify states; that makes it more readable if you're just eyeballing
it rather than fooling with Graphviz.  And rename a couple of identically
named struct fields to reduce confusion.

Per report from Corey Csuhta.  Add a test case based on his example.
(Note: this case does not trigger the bug under 9.3, apparently because
its different measurement of costs causes it to stop merging states before
it hits the failure.  I spent some time trying to find a variant that would
fail in 9.3, without success; but I'm sure such cases exist.)

Like the previous patch, back-patch to 9.3 where this code was added.

Report: https://postgr.es/m/E2B01A4B-4530-406B-8D17-2F67CF9A16BA@csuhta.com
2017-04-14 14:52:03 -04:00
..
adminpack Fix pg_file_write() error handling. 2017-03-12 19:35:57 -04:00
auth_delay Add file version information to most installed Windows binaries. 2014-07-14 14:07:52 -04:00
auto_explain Rearrange explain.c's API so callers need not embed sizeof(ExplainState). 2015-01-15 13:39:33 -05:00
btree_gin Make contrib regression tests safe for Danish locale. 2016-07-21 16:52:36 -04:00
btree_gist Properly initialize SortSupport for ORDER BY rechecks in nodeIndexscan.c. 2016-06-05 11:53:06 -04:00
chkpass Avoid returning undefined bytes in chkpass_in(). 2015-02-14 12:20:56 -05:00
citext Make contrib regression tests safe for Danish locale. 2016-07-21 16:52:36 -04:00
cube Fix typos in comments. 2017-02-06 11:34:18 +02:00
dblink Fix ancient connection leak in dblink 2017-03-11 13:32:40 -08:00
dict_int Update copyright for 2015 2015-01-06 11:43:47 -05:00
dict_xsyn Update copyright for 2015 2015-01-06 11:43:47 -05:00
earthdistance Fix typos in comments. 2017-02-06 11:34:18 +02:00
file_fdw Allow foreign and custom joins to handle EvalPlanQual rechecks. 2015-12-08 12:54:33 -05:00
fuzzystrmatch Remove new coupling between NAMEDATALEN and MAX_LEVENSHTEIN_STRLEN. 2016-01-22 11:53:06 -05:00
hstore Fix IsValidJsonNumber() to notice trailing non-alphanumeric garbage. 2016-02-03 01:39:08 -05:00
hstore_plperl Use LOAD not actual code execution to pull in plpython library. 2016-01-11 20:06:47 -05:00
hstore_plpython Use LOAD not actual code execution to pull in plpython library. 2016-01-11 20:06:47 -05:00
intagg Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
intarray Fix -e option in contrib/intarray/bench/bench.pl. 2016-08-17 15:51:10 -04:00
isn Fix typos in comments. 2017-02-06 11:34:18 +02:00
lo Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
ltree Spelling fixes 2017-03-14 13:45:51 -04:00
ltree_plpython Use LOAD not actual code execution to pull in plpython library. 2016-01-11 20:06:47 -05:00
oid2name Add file version information to most installed Windows binaries. 2014-07-14 14:07:52 -04:00
pageinspect Back-patch portability fixes for contrib/pageinspect/ginfuncs.c. 2016-11-04 12:37:29 -04:00
passwordcheck Update copyright for 2015 2015-01-06 11:43:47 -05:00
pg_buffercache pg_buffercache: Allow huge allocations. 2016-09-15 09:30:36 -04:00
pg_freespacemap Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
pg_prewarm Update copyright for 2015 2015-01-06 11:43:47 -05:00
pg_standby Fix typos in comments. 2017-02-06 11:34:18 +02:00
pg_stat_statements Fix typos in comments. 2017-02-06 11:34:18 +02:00
pg_trgm Further fix pg_trgm's extraction of trigrams from regular expressions. 2017-04-14 14:52:03 -04:00
pgcrypto Fix typos in comments. 2017-02-06 11:34:18 +02:00
pgrowlocks Fix handling of multixacts predating pg_upgrade 2016-06-24 18:29:28 -04:00
pgstattuple Remove unused macros. 2016-05-02 10:08:58 +03:00
postgres_fdw Invalidate cached plans on FDW option changes. 2017-01-06 14:12:52 -05:00
seg Fix typos in comments. 2017-02-06 11:34:18 +02:00
sepgsql Silence compiler warning in sepgsql 2017-04-06 14:24:44 -07:00
spi Fix typos in comments. 2017-02-06 11:34:18 +02:00
sslinfo Fix error message wording in previous sslinfo commit 2015-09-08 11:10:20 -03:00
start-scripts Fix typos in comments. 2017-02-06 11:34:18 +02:00
tablefunc Fix a number of places that produced XX000 errors in the regression tests. 2015-08-02 23:49:19 -04:00
tcn Update copyright for 2015 2015-01-06 11:43:47 -05:00
test_decoding Make contrib/test_decoding regression tests safe for CZ locale. 2016-11-21 20:39:28 -05:00
tsearch2 Fix typos in comments. 2017-02-06 11:34:18 +02:00
tsm_system_rows Redesign tablesample method API, and do extensive code review. 2015-07-25 14:39:00 -04:00
tsm_system_time Some platforms now need contrib/tsm_system_time to be linked with libm. 2015-07-25 16:37:22 -04:00
unaccent Update copyright for 2015 2015-01-06 11:43:47 -05:00
uuid-ossp Give a useful error message if uuid-ossp is built without preconfiguration. 2016-12-22 11:19:18 -05:00
vacuumlo vacuumlo: Avoid unlikely memory leak. 2015-01-14 15:14:20 -05:00
xml2 Fix typos in comments. 2017-02-06 11:34:18 +02:00
contrib-global.mk Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
Makefile Finish removing pg_audit 2015-05-28 12:48:25 -04:00
README Rename 'gmake' to 'make' in docs and recommended commands 2014-02-12 17:29:19 -05:00

README 

The PostgreSQL contrib tree
---------------------------

This subtree contains porting tools, analysis utilities, and plug-in
features that are not part of the core PostgreSQL system, mainly
because they address a limited audience or are too experimental to be
part of the main source tree.  This does not preclude their
usefulness.

User documentation for each module appears in the main SGML
documentation.

When building from the source distribution, these modules are not
built automatically, unless you build the "world" target.  You can
also build and install them all by running "make all" and "make
install" in this directory; or to build and install just one selected
module, do the same in that module's subdirectory.

Some directories supply new user-defined functions, operators, or
types.  To make use of one of these modules, after you have installed
the code you need to register the new SQL objects in the database
system by executing a CREATE EXTENSION command.  In a fresh database,
you can simply do

    CREATE EXTENSION module_name;

See the PostgreSQL documentation for more information about this
procedure.