mirror of
https://github.com/postgres/postgres.git
synced 2026-02-03 20:40:14 -05:00
4dbcb3f844
resolve_polymorphic_tupdesc() and resolve_polymorphic_argtypes() failed to cover the case of having to resolve anyarray given only an anyrange input. The bug was masked if anyelement was also used (as either input or output), which probably helps account for our not having noticed. While looking at this I noticed that resolve_generic_type() would produce the wrong answer if asked to make that same resolution. ISTM that resolve_generic_type() is confusingly defined and overly complex, so rather than fix it, let's just make funcapi.c do the specific lookups it requires for itself. With this change, resolve_generic_type() is not used anywhere, so remove it in HEAD. In the back branches, leave it alone (complete with bug) just in case any external code is using it. While we're here, make some other refactoring adjustments in funcapi.c with an eye to upcoming future expansion of the set of polymorphic types: * Simplify quick-exit tests by adding an overall have_polymorphic_result flag. This is about a wash now but will be a win when there are more flags. * Reduce duplication of code between resolve_polymorphic_tupdesc() and resolve_polymorphic_argtypes(). * Don't bother to validate correct matching of anynonarray or anyenum; the parser should have done that, and even if it didn't, just doing "return false" here would lead to a very confusing, off-point error message. (Really, "return false" in these two functions should only occur if the call_expr isn't supplied or we can't obtain data type info from it.) * For the same reason, throw an elog rather than "return false" if we fail to resolve a polymorphic type. The bug's been there since we added anyrange, so back-patch to all supported branches. Discussion: https://postgr.es/m/6093.1584202130@sss.pgh.pa.us |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| analyze.h | ||
| gramparse.h | ||
| kwlist.h | ||
| parse_agg.h | ||
| parse_clause.h | ||
| parse_coerce.h | ||
| parse_collate.h | ||
| parse_cte.h | ||
| parse_enr.h | ||
| parse_expr.h | ||
| parse_func.h | ||
| parse_node.h | ||
| parse_oper.h | ||
| parse_param.h | ||
| parse_relation.h | ||
| parse_target.h | ||
| parse_type.h | ||
| parse_utilcmd.h | ||
| parser.h | ||
| parsetree.h | ||
| scanner.h | ||
| scansup.h | ||