Tom Lane a2944d8724 Fix missed corner cases for grantable permissions on GUCs. ... We allow users to set the values of not-yet-loaded extension GUCs, remembering those values in "placeholder" GUC entries. When/if the extension is loaded later in the session, we need to verify that the user had permissions to set the GUC. That was done correctly before commit a0ffa885e, but as of that commit, we'd check the permissions of the active role when the LOAD happens, not the role that had set the value. (This'd be a security bug if it had made it into a released version.) In principle this is simple enough to fix: we just need to remember the exact role OID that set each GUC value, and use that not GetUserID() when verifying permissions. Maintaining that data in the guc.c data structures is slightly tedious, but fortunately it's all basically just copy-n-paste of the logic for tracking the GucSource of each setting, as we were already doing. Another oversight is that validate_option_array_item() hadn't been taught to check for granted GUC privileges. This appears to manifest only in that ALTER ROLE/DATABASE RESET ALL will fail to reset settings that the user should be allowed to reset. Patch by myself and Nathan Bossart, per report from Nathan Bossart. Back-patch to v15 where the faulty code came in. Discussion: https://postgr.es/m/20220706224727.GA2158260@nathanxps13		2022-07-19 17:22:31 -04:00
..
plperl	Fix missed corner cases for grantable permissions on GUCs.	2022-07-19 17:22:31 -04:00
plpgsql	Translation updates	2022-05-16 11:12:42 +02:00
plpython	PL/Python: Update guide to alternative expected files	2022-06-27 12:53:05 +02:00
tcl	PL/Tcl: Don't link with -lc explicitly	2022-06-23 09:36:12 +02:00
Makefile	Make distprep and *clean build targets recurse into all subdirectories.	2011-07-03 13:55:12 -04:00