mirror of
https://github.com/postgres/postgres.git
synced 2026-02-15 16:48:17 -05:00
50371df266
The existing code tried to do syscache lookups in an already-failed transaction, which is problematic to say the least. After some consideration of alternatives, the best fix seems to be to just drop type names from the error message altogether. The table and column names seem like sufficient localization. If the user is unsure what types are involved, she can check the local and remote table definitions. Having done that, we can also discard the LogicalRepTypMap hash table, which had no other use. Arguably, LOGICAL_REP_MSG_TYPE replication messages are now obsolete as well; but we should probably keep them in case some other use emerges. (The complexity of removing something from the replication protocol would likely outweigh any savings anyhow.) Masahiko Sawada and Bharath Rupireddy, per complaint from Andres Freund. Back-patch to v10 where this code originated. Discussion: https://postgr.es/m/20210106020229.ne5xnuu6wlondjpe@alap3.anarazel.de |
||
|---|---|---|
| .. | ||
| backup_manifest.h | ||
| basebackup.h | ||
| decode.h | ||
| logical.h | ||
| logicallauncher.h | ||
| logicalproto.h | ||
| logicalrelation.h | ||
| logicalworker.h | ||
| message.h | ||
| origin.h | ||
| output_plugin.h | ||
| pgoutput.h | ||
| reorderbuffer.h | ||
| slot.h | ||
| snapbuild.h | ||
| syncrep.h | ||
| walreceiver.h | ||
| walsender.h | ||
| walsender_private.h | ||
| worker_internal.h | ||