mirror of
https://github.com/postgres/postgres.git
synced 2026-05-28 04:35:45 -04:00
53b327f83e
When a standby is promoted, CleanupAfterArchiveRecovery() may decide to rename the final WAL file from the old timeline by adding ".partial" to the name. If WAL summarization is enabled and this file is renamed before its partial contents are summarized, WAL summarization breaks: the summarizer gets stuck at that point in the WAL stream and just errors out. To fix that, first make the startup process wait for WAL summarization to catch up before renaming the file. Generally, this should be quick, and if it's not, the user can shut off summarize_wal and try again. To make this fix work, also teach the WAL summarizer that after a promotion has occurred, no more WAL can appear on the previous timeline: previously, the WAL summarizer wouldn't switch to the new timeline until we actually started writing WAL there, but that meant that when the startup process was waiting for the WAL summarizer, it was waiting for an action that the summarizer wasn't yet prepared to take. In the process of fixing these bugs, I realized that the logic to wait for WAL summarization to catch up was spread out in a way that made it difficult to reuse properly, so this code refactors things to make it easier. Finally, add a test case that would have caught this bug and the previously-fixed bug that WAL summarization sometimes needs to back up when the timeline changes. Discussion: https://postgr.es/m/CA+TgmoZGEsZodXC4f=XZNkAeyuDmWTSkpkjCEOcF19Am0mt_OA@mail.gmail.com |
||
|---|---|---|
| .. | ||
| autovacuum.c | ||
| auxprocess.c | ||
| bgworker.c | ||
| bgwriter.c | ||
| checkpointer.c | ||
| fork_process.c | ||
| interrupt.c | ||
| launch_backend.c | ||
| Makefile | ||
| meson.build | ||
| pgarch.c | ||
| postmaster.c | ||
| startup.c | ||
| syslogger.c | ||
| walsummarizer.c | ||
| walwriter.c | ||