Dean Rasheed 556fdd49c9 Further fixing for multi-row VALUES lists for updatable views. ... Previously, rewriteTargetListIU() generated a list of attribute numbers from the targetlist, which were passed to rewriteValuesRTE(), which expected them to contain the same number of entries as there are columns in the VALUES RTE, and to be in the same order. That was fine when the target relation was a table, but for an updatable view it could be broken in at least three different ways --- rewriteTargetListIU() could insert additional targetlist entries for view columns with defaults, the view columns could be in a different order from the columns of the underlying base relation, and targetlist entries could be merged together when assigning to elements of an array or composite type. As a result, when recursing to the base relation, the list of attribute numbers generated from the rewritten targetlist could no longer be relied upon to match the columns of the VALUES RTE. We got away with that prior to 41531e42d3 because it used to always be the case that rewriteValuesRTE() did nothing for the underlying base relation, since all DEFAULTS had already been replaced when it was initially invoked for the view, but that was incorrect because it failed to apply defaults from the base relation. Fix this by examining the targetlist entries more carefully and picking out just those that are simple Vars referencing the VALUES RTE. That's sufficient for the purposes of rewriteValuesRTE(), which is only responsible for dealing with DEFAULT items in the VALUES RTE. Any DEFAULT item in the VALUES RTE that doesn't have a matching simple-Var-assignment in the targetlist is an error which we complain about, but in theory that ought to be impossible. Additionally, move this code into rewriteValuesRTE() to give a clearer separation of concerns between the 2 functions. There is no need for rewriteTargetListIU() to know about the details of the VALUES RTE. While at it, fix the comment for rewriteValuesRTE() which claimed that it doesn't support array element and field assignments --- that hasn't been true since a3c7a993d5 (9.6 and later). Back-patch to all supported versions, with minor differences for the pre-9.6 branches, which don't support array element and field assignments to the same column in multi-row VALUES lists. Reviewed by Amit Langote. Discussion: https://postgr.es/m/15623-5d67a46788ec8b7f@postgresql.org		2019-03-03 10:57:37 +00:00
..
backend	Further fixing for multi-row VALUES lists for updatable views.	2019-03-03 10:57:37 +00:00
bin	Tolerate EINVAL when calling fsync() on a directory.	2019-02-25 00:02:15 +13:00
common	Fix portability failure introduced in commits d2b0b60e7 et al.	2018-12-26 15:30:35 -05:00
include	Stamp 9.5.16.	2019-02-11 16:22:57 -05:00
interfaces	Fix ecpg bugs caused by missing semicolons in the backend grammar.	2019-02-24 12:51:51 -05:00
makefiles	Move port-specific parts of with_temp_install to port makefile.	2019-02-04 19:00:18 +00:00
pl	Translation updates	2019-02-11 14:15:25 +01:00
port	Stamp 9.5.16.	2019-02-11 16:22:57 -05:00
template	Yet further rethinking of build changes for macOS Mojave.	2018-11-02 18:54:00 -04:00
test	Further fixing for multi-row VALUES lists for updatable views.	2019-03-03 10:57:37 +00:00
timezone	Update time zone data files to tzdata release 2018i.	2019-02-05 10:59:31 -05:00
tools	Unify searchpath and do file logic in MSVC build scripts.	2019-02-06 07:55:10 -05:00
tutorial	Remove no-longer-required function declarations.	2015-05-24 12:20:23 -04:00
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	2010-09-22 12:57:04 +02:00
bcc32.mak	Autoconfiscate selection of 64-bit int type for 64-bit large object API.	2012-10-07 21:52:43 -04:00
DEVELOPERS	Replace a couple of references to files that no longer exist in the source	2009-05-04 08:08:47 +00:00
Makefile	Install TAP test infrastructure so it's available for extension testing.	2016-09-23 15:50:00 -04:00
Makefile.global.in	Move port-specific parts of with_temp_install to port makefile.	2019-02-04 19:00:18 +00:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk	nls-global.mk: search build dir for source files, too	2016-06-07 18:55:18 -04:00
win32.mak	Autoconfiscate selection of 64-bit int type for 64-bit large object API.	2012-10-07 21:52:43 -04:00