mirror of
https://github.com/postgres/postgres.git
synced 2026-02-10 06:13:34 -05:00
Previously tables declared WITH OIDS, including a significant fraction of the catalog tables, stored the oid column not as a normal column, but as part of the tuple header. This special column was not shown by default, which was somewhat odd, as it's often (consider e.g. pg_class.oid) one of the more important parts of a row. Neither pg_dump nor COPY included the contents of the oid column by default. The fact that the oid column was not an ordinary column necessitated a significant amount of special case code to support oid columns. That already was painful for the existing, but upcoming work aiming to make table storage pluggable, would have required expanding and duplicating that "specialness" significantly. WITH OIDS has been deprecated since 2005 (commit ff02d0a05280e0). Remove it. Removing includes: - CREATE TABLE and ALTER TABLE syntax for declaring the table to be WITH OIDS has been removed (WITH (oids[ = true]) will error out) - pg_dump does not support dumping tables declared WITH OIDS and will issue a warning when dumping one (and ignore the oid column). - restoring an pg_dump archive with pg_restore will warn when restoring a table with oid contents (and ignore the oid column) - COPY will refuse to load binary dump that includes oids. - pg_upgrade will error out when encountering tables declared WITH OIDS, they have to be altered to remove the oid column first. - Functionality to access the oid of the last inserted row (like plpgsql's RESULT_OID, spi's SPI_lastoid, ...) has been removed. The syntax for declaring a table WITHOUT OIDS (or WITH (oids = false) for CREATE TABLE) is still supported. While that requires a bit of support code, it seems unnecessary to break applications / dumps that do not use oids, and are explicit about not using them. The biggest user of WITH OID columns was postgres' catalog. This commit changes all 'magic' oid columns to be columns that are normally declared and stored. To reduce unnecessary query breakage all the newly added columns are still named 'oid', even if a table's column naming scheme would indicate 'reloid' or such. This obviously requires adapting a lot code, mostly replacing oid access via HeapTupleGetOid() with access to the underlying Form_pg_*->oid column. The bootstrap process now assigns oids for all oid columns in genbki.pl that do not have an explicit value (starting at the largest oid previously used), only oids assigned later by oids will be above FirstBootstrapObjectId. As the oid column now is a normal column the special bootstrap syntax for oids has been removed. Oids are not automatically assigned during insertion anymore, all backend code explicitly assigns oids with GetNewOidWithIndex(). For the rare case that insertions into the catalog via SQL are called for the new pg_nextoid() function can be used (which only works on catalog tables). The fact that oid columns on system tables are now normal columns means that they will be included in the set of columns expanded by * (i.e. SELECT * FROM pg_class will now include the table's oid, previously it did not). It'd not technically be hard to hide oid column by default, but that'd mean confusing behavior would either have to be carried forward forever, or it'd cause breakage down the line. While it's not unlikely that further adjustments are needed, the scope/invasiveness of the patch makes it worthwhile to get merge this now. It's painful to maintain externally, too complicated to commit after the code code freeze, and a dependency of a number of other patches. Catversion bump, for obvious reasons. Author: Andres Freund, with contributions by John Naylor Discussion: https://postgr.es/m/20180930034810.ywp2c7awz7opzcfr@alap3.anarazel.de
373 lines
6 KiB
SQL
373 lines
6 KiB
SQL
--
|
|
-- ERRORS
|
|
--
|
|
|
|
-- bad in postquel, but ok in PostgreSQL
|
|
select 1;
|
|
|
|
|
|
--
|
|
-- UNSUPPORTED STUFF
|
|
|
|
-- doesn't work
|
|
-- notify pg_class
|
|
--
|
|
|
|
--
|
|
-- SELECT
|
|
|
|
-- this used to be a syntax error, but now we allow an empty target list
|
|
select;
|
|
|
|
-- no such relation
|
|
select * from nonesuch;
|
|
|
|
-- bad name in target list
|
|
select nonesuch from pg_database;
|
|
|
|
-- empty distinct list isn't OK
|
|
select distinct from pg_database;
|
|
|
|
-- bad attribute name on lhs of operator
|
|
select * from pg_database where nonesuch = pg_database.datname;
|
|
|
|
-- bad attribute name on rhs of operator
|
|
select * from pg_database where pg_database.datname = nonesuch;
|
|
|
|
-- bad attribute name in select distinct on
|
|
select distinct on (foobar) * from pg_database;
|
|
|
|
|
|
--
|
|
-- DELETE
|
|
|
|
-- missing relation name (this had better not wildcard!)
|
|
delete from;
|
|
|
|
-- no such relation
|
|
delete from nonesuch;
|
|
|
|
|
|
--
|
|
-- DROP
|
|
|
|
-- missing relation name (this had better not wildcard!)
|
|
drop table;
|
|
|
|
-- no such relation
|
|
drop table nonesuch;
|
|
|
|
|
|
--
|
|
-- ALTER TABLE
|
|
|
|
-- relation renaming
|
|
|
|
-- missing relation name
|
|
alter table rename;
|
|
|
|
-- no such relation
|
|
alter table nonesuch rename to newnonesuch;
|
|
|
|
-- no such relation
|
|
alter table nonesuch rename to stud_emp;
|
|
|
|
-- conflict
|
|
alter table stud_emp rename to aggtest;
|
|
|
|
-- self-conflict
|
|
alter table stud_emp rename to stud_emp;
|
|
|
|
|
|
-- attribute renaming
|
|
|
|
-- no such relation
|
|
alter table nonesuchrel rename column nonesuchatt to newnonesuchatt;
|
|
|
|
-- no such attribute
|
|
alter table emp rename column nonesuchatt to newnonesuchatt;
|
|
|
|
-- conflict
|
|
alter table emp rename column salary to manager;
|
|
|
|
-- conflict
|
|
alter table emp rename column salary to ctid;
|
|
|
|
|
|
--
|
|
-- TRANSACTION STUFF
|
|
|
|
-- not in a xact
|
|
abort;
|
|
|
|
-- not in a xact
|
|
end;
|
|
|
|
|
|
--
|
|
-- CREATE AGGREGATE
|
|
|
|
-- sfunc/finalfunc type disagreement
|
|
create aggregate newavg2 (sfunc = int4pl,
|
|
basetype = int4,
|
|
stype = int4,
|
|
finalfunc = int2um,
|
|
initcond = '0');
|
|
|
|
-- left out basetype
|
|
create aggregate newcnt1 (sfunc = int4inc,
|
|
stype = int4,
|
|
initcond = '0');
|
|
|
|
|
|
--
|
|
-- DROP INDEX
|
|
|
|
-- missing index name
|
|
drop index;
|
|
|
|
-- bad index name
|
|
drop index 314159;
|
|
|
|
-- no such index
|
|
drop index nonesuch;
|
|
|
|
|
|
--
|
|
-- DROP AGGREGATE
|
|
|
|
-- missing aggregate name
|
|
drop aggregate;
|
|
|
|
-- missing aggregate type
|
|
drop aggregate newcnt1;
|
|
|
|
-- bad aggregate name
|
|
drop aggregate 314159 (int);
|
|
|
|
-- bad aggregate type
|
|
drop aggregate newcnt (nonesuch);
|
|
|
|
-- no such aggregate
|
|
drop aggregate nonesuch (int4);
|
|
|
|
-- no such aggregate for type
|
|
drop aggregate newcnt (float4);
|
|
|
|
|
|
--
|
|
-- DROP FUNCTION
|
|
|
|
-- missing function name
|
|
drop function ();
|
|
|
|
-- bad function name
|
|
drop function 314159();
|
|
|
|
-- no such function
|
|
drop function nonesuch();
|
|
|
|
|
|
--
|
|
-- DROP TYPE
|
|
|
|
-- missing type name
|
|
drop type;
|
|
|
|
-- bad type name
|
|
drop type 314159;
|
|
|
|
-- no such type
|
|
drop type nonesuch;
|
|
|
|
|
|
--
|
|
-- DROP OPERATOR
|
|
|
|
-- missing everything
|
|
drop operator;
|
|
|
|
-- bad operator name
|
|
drop operator equals;
|
|
|
|
-- missing type list
|
|
drop operator ===;
|
|
|
|
-- missing parentheses
|
|
drop operator int4, int4;
|
|
|
|
-- missing operator name
|
|
drop operator (int4, int4);
|
|
|
|
-- missing type list contents
|
|
drop operator === ();
|
|
|
|
-- no such operator
|
|
drop operator === (int4);
|
|
|
|
-- no such operator by that name
|
|
drop operator === (int4, int4);
|
|
|
|
-- no such type1
|
|
drop operator = (nonesuch);
|
|
|
|
-- no such type1
|
|
drop operator = ( , int4);
|
|
|
|
-- no such type1
|
|
drop operator = (nonesuch, int4);
|
|
|
|
-- no such type2
|
|
drop operator = (int4, nonesuch);
|
|
|
|
-- no such type2
|
|
drop operator = (int4, );
|
|
|
|
|
|
--
|
|
-- DROP RULE
|
|
|
|
-- missing rule name
|
|
drop rule;
|
|
|
|
-- bad rule name
|
|
drop rule 314159;
|
|
|
|
-- no such rule
|
|
drop rule nonesuch on noplace;
|
|
|
|
-- these postquel variants are no longer supported
|
|
drop tuple rule nonesuch;
|
|
drop instance rule nonesuch on noplace;
|
|
drop rewrite rule nonesuch;
|
|
|
|
--
|
|
-- Check that division-by-zero is properly caught.
|
|
--
|
|
|
|
select 1/0;
|
|
|
|
select 1::int8/0;
|
|
|
|
select 1/0::int8;
|
|
|
|
select 1::int2/0;
|
|
|
|
select 1/0::int2;
|
|
|
|
select 1::numeric/0;
|
|
|
|
select 1/0::numeric;
|
|
|
|
select 1::float8/0;
|
|
|
|
select 1/0::float8;
|
|
|
|
select 1::float4/0;
|
|
|
|
select 1/0::float4;
|
|
|
|
|
|
--
|
|
-- Test psql's reporting of syntax error location
|
|
--
|
|
|
|
xxx;
|
|
|
|
CREATE foo;
|
|
|
|
CREATE TABLE ;
|
|
|
|
CREATE TABLE
|
|
\g
|
|
|
|
INSERT INTO foo VALUES(123) foo;
|
|
|
|
INSERT INTO 123
|
|
VALUES(123);
|
|
|
|
INSERT INTO foo
|
|
VALUES(123) 123
|
|
;
|
|
|
|
-- with a tab
|
|
CREATE TABLE foo
|
|
(id INT4 UNIQUE NOT NULL, id2 TEXT NOT NULL PRIMARY KEY,
|
|
id3 INTEGER NOT NUL,
|
|
id4 INT4 UNIQUE NOT NULL, id5 TEXT UNIQUE NOT NULL);
|
|
|
|
-- long line to be truncated on the left
|
|
CREATE TABLE foo(id INT4 UNIQUE NOT NULL, id2 TEXT NOT NULL PRIMARY KEY, id3 INTEGER NOT NUL,
|
|
id4 INT4 UNIQUE NOT NULL, id5 TEXT UNIQUE NOT NULL);
|
|
|
|
-- long line to be truncated on the right
|
|
CREATE TABLE foo(
|
|
id3 INTEGER NOT NUL, id4 INT4 UNIQUE NOT NULL, id5 TEXT UNIQUE NOT NULL, id INT4 UNIQUE NOT NULL, id2 TEXT NOT NULL PRIMARY KEY);
|
|
|
|
-- long line to be truncated both ways
|
|
CREATE TABLE foo(id INT4 UNIQUE NOT NULL, id2 TEXT NOT NULL PRIMARY KEY, id3 INTEGER NOT NUL, id4 INT4 UNIQUE NOT NULL, id5 TEXT UNIQUE NOT NULL);
|
|
|
|
-- long line to be truncated on the left, many lines
|
|
CREATE
|
|
TEMPORARY
|
|
TABLE
|
|
foo(id INT4 UNIQUE NOT NULL, id2 TEXT NOT NULL PRIMARY KEY, id3 INTEGER NOT NUL,
|
|
id4 INT4
|
|
UNIQUE
|
|
NOT
|
|
NULL,
|
|
id5 TEXT
|
|
UNIQUE
|
|
NOT
|
|
NULL)
|
|
;
|
|
|
|
-- long line to be truncated on the right, many lines
|
|
CREATE
|
|
TEMPORARY
|
|
TABLE
|
|
foo(
|
|
id3 INTEGER NOT NUL, id4 INT4 UNIQUE NOT NULL, id5 TEXT UNIQUE NOT NULL, id INT4 UNIQUE NOT NULL, id2 TEXT NOT NULL PRIMARY KEY)
|
|
;
|
|
|
|
-- long line to be truncated both ways, many lines
|
|
CREATE
|
|
TEMPORARY
|
|
TABLE
|
|
foo
|
|
(id
|
|
INT4
|
|
UNIQUE NOT NULL, idx INT4 UNIQUE NOT NULL, idy INT4 UNIQUE NOT NULL, id2 TEXT NOT NULL PRIMARY KEY, id3 INTEGER NOT NUL, id4 INT4 UNIQUE NOT NULL, id5 TEXT UNIQUE NOT NULL,
|
|
idz INT4 UNIQUE NOT NULL,
|
|
idv INT4 UNIQUE NOT NULL);
|
|
|
|
-- more than 10 lines...
|
|
CREATE
|
|
TEMPORARY
|
|
TABLE
|
|
foo
|
|
(id
|
|
INT4
|
|
UNIQUE
|
|
NOT
|
|
NULL
|
|
,
|
|
idm
|
|
INT4
|
|
UNIQUE
|
|
NOT
|
|
NULL,
|
|
idx INT4 UNIQUE NOT NULL, idy INT4 UNIQUE NOT NULL, id2 TEXT NOT NULL PRIMARY KEY, id3 INTEGER NOT NUL, id4 INT4 UNIQUE NOT NULL, id5 TEXT UNIQUE NOT NULL,
|
|
idz INT4 UNIQUE NOT NULL,
|
|
idv
|
|
INT4
|
|
UNIQUE
|
|
NOT
|
|
NULL);
|
|
|
|
-- Check that stack depth detection mechanism works and
|
|
-- max_stack_depth is not set too high
|
|
create function infinite_recurse() returns int as
|
|
'select infinite_recurse()' language sql;
|
|
\set VERBOSITY terse
|
|
select infinite_recurse();
|