mirror of
https://github.com/postgres/postgres.git
synced 2026-04-01 23:36:06 -04:00
5c80642aa8
These functions were originally added in commit d8cedf67a to support
use of int2vector columns as catcache lookup keys. However, there are
no catcaches that use such columns. (Indeed I now think it must always
have been dead code: a catcache with such a key column would need an
underlying unique index on the column, but we've never had an int2vector
btree opclass.)
Getting rid of the int2vector-specific operator and function does not
lose any functionality, because operations on int2vectors will now fall
back to the generic anyarray support. This avoids a wart that a btree
index on an int2vector column (made using anyarray_ops) would fail to
match equality searches, because int2vectoreq wasn't a member of the
opclass. We don't really care much about that, since int2vector is not
meant as a type for users to use, but it's silly to have extra code and
less functionality.
If we ever do want a catcache to be indexed by an int2vector column,
we'd need to put back full btree and hash opclasses for int2vector,
comparable to the support for oidvector. (The anyarray code can't be
used at such a low level, because it needs to do catcache lookups.)
But we'll deal with that if/when the need arises.
Also worth noting is that removal of the hash int2vector_ops opclass will
break any user-created hash indexes on int2vector columns. While hash
anyarray_ops would serve the same purpose, it would probably not compute
the same hash values and thus wouldn't be on-disk-compatible. Given that
int2vector isn't a user-facing type and we're planning other incompatible
changes in hash indexes for v10 anyway, this doesn't seem like something
to worry about, but it's probably worth mentioning here.
Amit Langote
Discussion: <d9bb74f8-b194-7307-9ebd-90645d377e45@lab.ntt.co.jp>
58 lines
2.5 KiB
C
58 lines
2.5 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* catversion.h
|
|
* "Catalog version number" for PostgreSQL.
|
|
*
|
|
* The catalog version number is used to flag incompatible changes in
|
|
* the PostgreSQL system catalogs. Whenever anyone changes the format of
|
|
* a system catalog relation, or adds, deletes, or modifies standard
|
|
* catalog entries in such a way that an updated backend wouldn't work
|
|
* with an old database (or vice versa), the catalog version number
|
|
* should be changed. The version number stored in pg_control by initdb
|
|
* is checked against the version number compiled into the backend at
|
|
* startup time, so that a backend can refuse to run in an incompatible
|
|
* database.
|
|
*
|
|
* The point of this feature is to provide a finer grain of compatibility
|
|
* checking than is possible from looking at the major version number
|
|
* stored in PG_VERSION. It shouldn't matter to end users, but during
|
|
* development cycles we usually make quite a few incompatible changes
|
|
* to the contents of the system catalogs, and we don't want to bump the
|
|
* major version number for each one. What we can do instead is bump
|
|
* this internal version number. This should save some grief for
|
|
* developers who might otherwise waste time tracking down "bugs" that
|
|
* are really just code-vs-database incompatibilities.
|
|
*
|
|
* The rule for developers is: if you commit a change that requires
|
|
* an initdb, you should update the catalog version number (as well as
|
|
* notifying the pghackers mailing list, which has been the informal
|
|
* practice for a long time).
|
|
*
|
|
* The catalog version number is placed here since modifying files in
|
|
* include/catalog is the most common kind of initdb-forcing change.
|
|
* But it could be used to protect any kind of incompatible change in
|
|
* database contents or layout, such as altering tuple headers.
|
|
*
|
|
*
|
|
* Portions Copyright (c) 1996-2016, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/catalog/catversion.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef CATVERSION_H
|
|
#define CATVERSION_H
|
|
|
|
/*
|
|
* We could use anything we wanted for version numbers, but I recommend
|
|
* following the "YYYYMMDDN" style often used for DNS zone serial numbers.
|
|
* YYYYMMDD are the date of the change, and N is the number of the change
|
|
* on that day. (Hopefully we'll never commit ten independent sets of
|
|
* catalog changes on the same day...)
|
|
*/
|
|
|
|
/* yyyymmddN */
|
|
#define CATALOG_VERSION_NO 201610121
|
|
|
|
#endif
|