mirror of
https://github.com/postgres/postgres.git
synced 2026-02-16 00:57:52 -05:00
6ff385f20c
The meson build scripts attempt to find files left over from configure and fail, mentioning that "make maintainer-clean" should be run to remove these. This seems to have been done for files generated from configure. pg_config_paths.h is generated during the actual make build, so seems to have been missed. This would result in compilation using the wrong pg_config_paths.h file. Here we just add this file to generated_sources_ac so that meson errors out if pg_config_paths.h exists. Likely this wasn't noticed before because make maintainer-clean will remove pg_config_paths.h, however, people using the MSVC build scripts are more likely to run into issues and they have to manually remove these files and pg_config_paths.h wasn't listed as a conflicting file to remove in the meson log. Backpatch-through: 16, where meson support was added Discussion: https://postgr.es/m/CAApHDvqjYOxZfmLKAOWKFEE7LOr9_E6UA6YNmx9r8nxStcS3gg@mail.gmail.com |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| bsearch_arg.c | ||
| chklocale.c | ||
| dirent.c | ||
| dirmod.c | ||
| explicit_bzero.c | ||
| getopt.c | ||
| getopt_long.c | ||
| getpeereid.c | ||
| inet_aton.c | ||
| inet_net_ntop.c | ||
| kill.c | ||
| Makefile | ||
| meson.build | ||
| mkdtemp.c | ||
| noblock.c | ||
| open.c | ||
| path.c | ||
| pg_bitutils.c | ||
| pg_crc32c_armv8.c | ||
| pg_crc32c_armv8_choose.c | ||
| pg_crc32c_loongarch.c | ||
| pg_crc32c_sb8.c | ||
| pg_crc32c_sse42.c | ||
| pg_crc32c_sse42_choose.c | ||
| pg_strong_random.c | ||
| pgcheckdir.c | ||
| pgmkdirp.c | ||
| pgsleep.c | ||
| pgstrcasecmp.c | ||
| pgstrsignal.c | ||
| pqsignal.c | ||
| preadv.c | ||
| pthread-win32.h | ||
| pthread_barrier_wait.c | ||
| pwritev.c | ||
| qsort.c | ||
| qsort_arg.c | ||
| quotes.c | ||
| README | ||
| snprintf.c | ||
| strerror.c | ||
| strlcat.c | ||
| strlcpy.c | ||
| strnlen.c | ||
| strtof.c | ||
| system.c | ||
| tar.c | ||
| user.c | ||
| win32.ico | ||
| win32common.c | ||
| win32dlopen.c | ||
| win32env.c | ||
| win32error.c | ||
| win32fdatasync.c | ||
| win32fseek.c | ||
| win32getrusage.c | ||
| win32gettimeofday.c | ||
| win32link.c | ||
| win32ntdll.c | ||
| win32pread.c | ||
| win32pwrite.c | ||
| win32security.c | ||
| win32setlocale.c | ||
| win32stat.c | ||
| win32ver.rc | ||
src/port/README
libpgport
=========
libpgport must have special behavior. It supplies functions to both
libraries and applications. However, there are two complexities:
1) Libraries need to use object files that are compiled with exactly
the same flags as the library. libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries. This is done by removing -lpgport from the link line:
# Need to recompile any libpgport object files
LIBS := $(filter-out -lpgport, $(LIBS))
and adding infrastructure to recompile the object files:
OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
connect.o misc.o path.o exec.o \
$(filter strlcat.o, $(LIBOBJS))
The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.
2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first. This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq. libpq's libpgport usage changes over time, so such a
dependency is a problem. Windows, Linux, AIX, and macOS use an export
list to control the symbols exported by libpq.