Tom Lane 5fe0ab4201 Fix failure to remove non-first segments of temporary tables. ... Commit 4ab5dae94 broke mdunlinkfork's logic for removing additional segments of a multi-gigabyte table, because it neglected to advance "segno" after unlinking the first segment, in the code path where it chooses to unlink that one immediately. Then the main remove loop gets ENOENT at segment zero and figures it's done, so we never remove whatever additional segments might exist. The main problem here is with large temporary tables, but WAL replay of a drop of a large regular table would also fail to remove extra segments. The third case where this path is taken is for non-main forks; but I doubt it matters for those since they probably never exceed 1GB. The simplest fix is just to increment segno after that unlink(). (Probably this logic could do with a more thorough rethink, but not with mere hours to go before 15.1 wraps.) While here, also fix an incautious assumption that register_forget_request cannot change errno. I don't think that that has any really bad consequences, as we'd end up trying to unlink the zero'th segment either way, but it greatly complicates reasoning about what could happen here. Also make a couple of other cosmetic fixes. Per bug #17679 from Balazs Szilfai. Back-patch into v15, as the faulty patch was. Discussion: https://postgr.es/m/17679-1095d04450cf6a6e@postgresql.org		2022-11-07 11:36:45 -05:00
..
backend	Fix failure to remove non-first segments of temporary tables.	2022-11-07 11:36:45 -05:00
bin	Translation updates	2022-11-07 14:04:05 +01:00
common	Change some errdetail() to errdetail_internal()	2022-09-28 17:14:53 +02:00
fe_utils	Use correct connection for cancellation in frontend's parallel slots	2022-08-27 15:22:07 +09:00
include	Fix CREATE DATABASE so we can pg_upgrade DBs with OIDs above 2^31.	2022-11-04 10:39:52 -04:00
interfaces	Translation updates	2022-11-07 14:04:05 +01:00
makefiles	Refactor DLSUFFIX handling	2022-03-25 08:56:02 +01:00
pl	Translation updates	2022-11-07 14:04:05 +01:00
port	Use libc's snprintf, not sprintf, for special cases in snprintf.c.	2022-10-16 11:47:44 -04:00
template	On NetBSD, force dynamic symbol resolution at postmaster start.	2022-08-30 17:28:55 -04:00
test	Correct error message for row-level triggers with transition tables on partitioned tables.	2022-11-04 19:15:01 +09:00
timezone	Update time zone data files to tzdata release 2022f.	2022-11-01 17:08:49 -04:00
tools	ci: Add hint about downloadable logs to README	2022-09-26 20:03:37 -07:00
tutorial	Update copyright for 2022	2022-01-07 19:04:57 -05:00
.gitignore
DEVELOPERS
Makefile	Remove the option to build thread_test.c outside configure.	2020-10-21 12:08:48 -04:00
Makefile.global.in	Increase minimum supported GNU make version to 3.81.	2022-07-23 12:12:42 -04:00
Makefile.shlib	AIX: Fix missing libpq symbols by respecting SHLIB_EXPORTS.	2021-09-06 11:27:59 -07:00
nls-global.mk	Improve frontend error logging style.	2022-04-08 14:55:14 -04:00