Andres Freund 60e97d63e5 Fix crash caused by EPQ happening with a before update trigger present. ... When ExecBRUpdateTriggers()'s GetTupleForTrigger() follows an EPQ chain the former needs to run the result tuple through the junkfilter again, and update the slot containing the new version of the tuple to contain that new version. The input tuple may already be in the junkfilter's output slot, which used to be OK - we don't need the previous version anymore. Unfortunately ff11e7f4b9 started to use ExecCopySlot() to update newslot, and ExecCopySlot() doesn't support copying a slot into itself, leading to a slot in a corrupt state, which then can cause crashes or other symptoms. Fix this by skipping the ExecCopySlot() when copying into itself. While we could have easily made ExecCopySlot() handle that case, it seems better to add an assert forbidding doing so instead. As the goal of copying might be to make the contents of one slot independent from another, it seems failure prone to handle doing so silently. A follow-up commit will add tests for the obviously under-covered combination of EPQ and triggers. Done as a separate commit as it might make sense to backpatch them further than this bug. Also remove confusion with confusing variable names for slots in ExecBRDeleteTriggers() and ExecBRUpdateTriggers(). Bug: #16036 Reported-By: Антон Власов Author: Andres Freund Discussion: https://postgr.es/m/16036-28184c90d952fb7f@postgresql.org Backpatch: 12-, where ff11e7f4b9 was merged		2019-10-04 13:57:37 -07:00
..
backend	Fix crash caused by EPQ happening with a before update trigger present.	2019-10-04 13:57:37 -07:00
bin	Fix --dry-run mode of pg_rewind	2019-10-04 09:16:03 +09:00
common	In pg_log_generic(), be more paranoid about preserving errno.	2019-07-06 11:25:48 -04:00
fe_utils	Update stale comments, and fix comment typos.	2019-06-08 10:12:26 -07:00
include	Fix crash caused by EPQ happening with a before update trigger present.	2019-10-04 13:57:37 -07:00
interfaces	Translation updates	2019-09-29 23:57:17 +02:00
makefiles	Define WIN32_STACK_RLIMIT throughout win32 and cygwin builds.	2019-04-09 08:25:39 -07:00
pl	Translation updates	2019-09-29 23:57:17 +02:00
port	Improve what pg_strsignal prints if we haven't got strsignal(3).	2019-08-27 17:24:30 -04:00
template	Yet further rethinking of build changes for macOS Mojave.	2018-11-02 18:54:00 -04:00
test	Fix bitshiftright()'s zero-padding some more.	2019-10-04 10:34:21 -04:00
timezone	Update time zone data files to tzdata release 2019c.	2019-09-20 19:53:52 -04:00
tools	Handle spaces in OpenSSL install location for MSVC	2019-10-04 15:39:27 -04:00
tutorial	Phase 2 pgindent run for v12.	2019-05-22 13:04:48 -04:00
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	2010-09-22 12:57:04 +02:00
DEVELOPERS
Makefile	Fix partial-build problems introduced by having more generated headers.	2018-04-09 16:42:10 -04:00
Makefile.global.in	Consistently test for in-use shared memory.	2019-04-12 22:36:38 -07:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk	NLS: Fix backend gettext triggers	2019-09-23 09:05:50 +02:00