mirror of
https://github.com/postgres/postgres.git
synced 2026-04-09 02:56:13 -04:00
681dbe7d45
There was a window in RestoreBackupBlock where a page would be zeroed out, but not yet locked. If a backend pinned and locked the page in that window, it saw the zeroed page instead of the old page or new page contents, which could lead to missing rows in a result set, or errors. To fix, replace RBM_ZERO with RBM_ZERO_AND_LOCK, which atomically pins, zeroes, and locks the page, if it's not in the buffer cache already. In stable branches, the old RBM_ZERO constant is renamed to RBM_DO_NOT_USE, to avoid breaking any 3rd party extensions that might use RBM_ZERO. More importantly, this avoids renumbering the other enum values, which would cause even bigger confusion in extensions that use ReadBufferExtended, but haven't been recompiled. Backpatch to all supported versions; this has been racy since hot standby was introduced. |
||
|---|---|---|
| .. | ||
| backendid.h | ||
| block.h | ||
| buf.h | ||
| buf_internals.h | ||
| buffile.h | ||
| bufmgr.h | ||
| bufpage.h | ||
| fd.h | ||
| freespace.h | ||
| fsm_internals.h | ||
| indexfsm.h | ||
| ipc.h | ||
| item.h | ||
| itemid.h | ||
| itemptr.h | ||
| large_object.h | ||
| lmgr.h | ||
| lock.h | ||
| lwlock.h | ||
| off.h | ||
| pg_sema.h | ||
| pg_shmem.h | ||
| pmsignal.h | ||
| pos.h | ||
| proc.h | ||
| procarray.h | ||
| procsignal.h | ||
| relfilenode.h | ||
| s_lock.h | ||
| shmem.h | ||
| sinval.h | ||
| sinvaladt.h | ||
| smgr.h | ||
| spin.h | ||
| standby.h | ||